Skip to content

REF: Simplify JoinUnit.is_na for categorical #20833

Closed
@TomAugspurger

Description

@TomAugspurger

In JoinUnit.is_na we get the categories

if self.block.is_categorical:
values_flat = values.categories

and then check if they're all not na. Categories can't have NA in them, so we can just return False (I think).

Metadata

Metadata

Assignees

No one assigned

    Labels

    CategoricalCategorical Data TypeClosing CandidateMay be closeable, needs more eyeballsInternalsRelated to non-user accessible pandas implementationRefactorInternal refactoring of code

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions