-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: failure on s3 mocking #20720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@TomAugspurger any idea? |
cc @martindurant, have you been dealing with moto / requests issues recently? I think getmoto/moto#1026 is the one. |
The referenced issue causes anything based on requests to fail following the use of moto in some cases. In this particular case, though, the test is using moto, right? The following fixed the problem with requests: https://github.com/dask/dask/blob/master/dask/bytes/tests/test_s3.py#L46 |
Hi all; I'm one of the maintainers of Moto. Our most recent version had a regex bug in catching certain S3 urls to patch. We are releasing a new version in the next couple minutes that should resolve any issues ( Feel free to ping me if these issues don't seem to go away. |
thanks @spulec! |
Thanks @spulec, I can confirm that upgrading to 1.3.3 fixed things for me locally! We still have some failures on our CI, though I think that this is fully pandas problem now: https://travis-ci.org/TomAugspurger/pandas/jobs/369087870. The potential problem, we're mixing pip & conda installs in various orders, so our env looks like
So who knows which versions are active. Cleaning that up now. |
Okay, let me know if it does end up pointing back to Moto. |
Hi @spulec! I installed 1.3.5 today and it seems that it's mocking any requests not belonging to AWS. Are there other updates to consider or workarounds? Thanks! |
@csolamx feel free to follow along at getmoto/moto#1567 |
master seems to fail recently: https://travis-ci.org/pandas-dev/pandas/jobs/367585545
on
pandas/tests/iotest_parquet.py -k s3
.works locally for me. very odd as this is mocked and shouldn't ever have a connection error.
In particular xfailing: 336fba7
test_read_csv_chunked_download
inpandas.tests.io.test_network.py
test_s3_roundtrip
for fp & pyarrow inpandas.testsio.test_parquet.py
The text was updated successfully, but these errors were encountered: