Skip to content

TST: failure on s3 mocking #20720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
jreback opened this issue Apr 17, 2018 · 9 comments
Closed
2 tasks

TST: failure on s3 mocking #20720

jreback opened this issue Apr 17, 2018 · 9 comments
Labels
IO Parquet parquet, feather Testing pandas testing functions or related to the test suite
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Apr 17, 2018

master seems to fail recently: https://travis-ci.org/pandas-dev/pandas/jobs/367585545

on pandas/tests/iotest_parquet.py -k s3.

works locally for me. very odd as this is mocked and shouldn't ever have a connection error.

In particular xfailing: 336fba7

  • test_read_csv_chunked_download in pandas.tests.io.test_network.py
  • test_s3_roundtrip for fp & pyarrow in pandas.testsio.test_parquet.py
@jreback jreback added Testing pandas testing functions or related to the test suite IO Parquet parquet, feather labels Apr 17, 2018
@jreback jreback added this to the 0.23.0 milestone Apr 17, 2018
@jreback
Copy link
Contributor Author

jreback commented Apr 17, 2018

@TomAugspurger any idea?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Apr 18, 2018

cc @martindurant, have you been dealing with moto / requests issues recently?

I think getmoto/moto#1026 is the one.

@martindurant
Copy link
Contributor

martindurant commented Apr 18, 2018

The referenced issue causes anything based on requests to fail following the use of moto in some cases. In this particular case, though, the test is using moto, right?

The following fixed the problem with requests: https://github.com/dask/dask/blob/master/dask/bytes/tests/test_s3.py#L46

@spulec
Copy link

spulec commented Apr 18, 2018

Hi all; I'm one of the maintainers of Moto.

Our most recent version had a regex bug in catching certain S3 urls to patch. We are releasing a new version in the next couple minutes that should resolve any issues (1.3.3).

Feel free to ping me if these issues don't seem to go away.

@jreback
Copy link
Contributor Author

jreback commented Apr 18, 2018

thanks @spulec!

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Apr 20, 2018

Thanks @spulec, I can confirm that upgrading to 1.3.3 fixed things for me locally!

We still have some failures on our CI, though I think that this is fully pandas problem now: https://travis-ci.org/TomAugspurger/pandas/jobs/369087870.

The potential problem, we're mixing pip & conda installs in various orders, so our env looks like

boto                      2.48.0                    <pip>
boto3                     1.7.5                     <pip>
boto3                     1.7.4                    py27_0  
botocore                  1.10.5                    <pip>
botocore                  1.10.4                   py27_0  

So who knows which versions are active. Cleaning that up now.

@spulec
Copy link

spulec commented Apr 20, 2018

Okay, let me know if it does end up pointing back to Moto.

jreback added a commit that referenced this issue Apr 21, 2018
xfail problematic s3 / moto tests
@csolamx
Copy link

csolamx commented Sep 6, 2018

Hi @spulec! I installed 1.3.5 today and it seems that it's mocking any requests not belonging to AWS. Are there other updates to consider or workarounds?

Thanks!

@spulec
Copy link

spulec commented Sep 22, 2018

@csolamx feel free to follow along at getmoto/moto#1567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Parquet parquet, feather Testing pandas testing functions or related to the test suite
Projects
None yet
Development

No branches or pull requests

5 participants