Skip to content

BUG: no tables found in test_html spam test #20685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Apr 13, 2018 · 1 comment · Fixed by #20689
Closed

BUG: no tables found in test_html spam test #20685

jreback opened this issue Apr 13, 2018 · 1 comment · Fixed by #20689
Labels
good first issue IO HTML read_html, to_html, Styler.apply, Styler.applymap Unreliable Test Unit tests that occasionally fail
Milestone
0.23.0

Comments

@jreback
Copy link
Contributor

jreback commented Apr 13, 2018 

(pandas) bash-3.2$ pytest pandas/tests/io/test_html.py  -k spam_url --pdb -v
========================================================================================================================= test session starts =========================================================================================================================
platform darwin -- Python 3.6.3, pytest-3.3.0, py-1.5.2, pluggy-0.6.0 -- /Users/jreback/miniconda3/envs/pandas/bin/python
cachedir: .cache
rootdir: /Users/jreback/pandas, inifile: setup.cfg
plugins: xdist-1.20.1, forked-0.2, cov-2.5.1, hypothesis-3.38.5
collected 145 items                                                                                                                                                                                                                                                   

pandas/tests/io/test_html.py::TestReadHtml::test_spam_url[bs4] xfail                                                                                                                                                                                            [ 50%]
pandas/tests/io/test_html.py::TestReadHtml::test_spam_url[lxml] xfail                                                                                                                                                                                           [100%]

I have disabled these test as they just started failing. If anyone wants to investigate would be great!
@jreback jreback added IO HTML read_html, to_html, Styler.apply, Styler.applymap Unreliable Test Unit tests that occasionally fail Effort Low good first issue labels Apr 13, 2018
@jreback jreback added this to the Next Major Release milestone Apr 13, 2018
jreback added a commit that referenced this issue Apr 13, 2018
@jreback
TST: xfail test_spam_url in test_html.py as maybe page changed?
0e42a99 
xref #20685
@WillAyd
Copy link
Member

WillAyd commented Apr 13, 2018

I think the URL this was pointing to was simply changed or taken down:

image

@WillAyd WillAyd mentioned this issue Apr 13, 2018
Merged
4 tasks
@jorisvandenbossche jorisvandenbossche modified the milestones: Next Major Release, 0.23.0 Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue IO HTML read_html, to_html, Styler.apply, Styler.applymap Unreliable Test Unit tests that occasionally fail
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

Updated URL for spam test WillAyd/pandas
3 participants
@WillAyd @jreback @jorisvandenbossche