-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DataFrame.asof() fails when some columns are NaN #20652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
yeah this is correct.
welcome for you to have a look see and PR even better! |
Ok @jreback will try and take a look over the weekend. Also thanks for everything u do for pandas/open source. Its very much appreciated :) |
@jreback I also think this behavior is weird, but is it really a bug? In docs,
http://pandas.pydata.org/pandas-docs/version/0.19.0/generated/pandas.DataFrame.asof.html |
It doesn't seem like a bug. Docs specify that unless subset is specified, all the columns are being considered.
However, the phrasing might not be obvious, I'll try to improve the docs. |
Now I'm confused about the expected result of the asof function. For instance, If I put 7 in the last entry of the first row
the asof function gives
but
gives
These results are not supposed to be the same ? |
Code Sample, a copy-pastable example if possible
Problem description
NaN's in column 'b' should not affect asof() on column 'a'
Expected Output
Output of
pd.show_versions()
pandas: 0.22.0
numpy 1.14.2
The text was updated successfully, but these errors were encountered: