-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Ensure S3 tests are mocked #19825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
we could also sign up for an aws account with NuMFOCUS. would be minimal cost I think. |
Yeah, it'd be good to have one non-mocked test under a bucket we have
control over.
…On Wed, Feb 21, 2018 at 5:48 PM, Jeff Reback ***@***.***> wrote:
we could also sign up for an aws account with NuMFOCUS. would be minimal
cost I think.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19825 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIlXgnYIhoxcCDsVONxpkKOOsxOt0ks5tXKtCgaJpZM4SOS16>
.
|
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this issue
Mar 19, 2018
TomAugspurger
added a commit
that referenced
this issue
Mar 23, 2018
* REF: Mock all S3 Tests Closes #19825
We've temporarily set the pandas-test bucket to be unreadable, and it'll be going away entirely soon. Tests still pass for me locally, so hopefully things are OK. There's one reference to |
javadnoorb
pushed a commit
to javadnoorb/pandas
that referenced
this issue
Mar 29, 2018
* REF: Mock all S3 Tests Closes pandas-dev#19825
dworvos
pushed a commit
to dworvos/pandas
that referenced
this issue
Apr 2, 2018
* REF: Mock all S3 Tests Closes pandas-dev#19825
kornilova203
pushed a commit
to kornilova203/pandas
that referenced
this issue
Apr 23, 2018
* REF: Mock all S3 Tests Closes pandas-dev#19825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Anaconda owns the
pandas-test
S3 bucket that we use for some of our tests. They're doing some spring cleaning, and would like to remove this bucket sometime next week.We'll need to make sure that all of our tests are mocked.
From what I can tell,
pandas/tests/io/parser/test_network::TestS3
is not mocked.We also have an ASV benchmark that hits S3, whose goal is to ensure that we don't read the whole file when doing
read_csv(..., nrows=10)
. I think we could remove that and replace it with a mocked fixture that asserts something about the number of bytes read.The text was updated successfully, but these errors were encountered: