Skip to content

TST: broken tests as data not installed #18870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Dec 20, 2017 · 3 comments · Fixed by #18873
Closed

TST: broken tests as data not installed #18870

jreback opened this issue Dec 20, 2017 · 3 comments · Fixed by #18873
Labels
Testing pandas testing functions or related to the test suite
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Dec 20, 2017

skipping these tests: #18873

conda install is finally working. surfacing some failing tests because of data files not being installed.
https://travis-ci.org/pandas-dev/pandas/jobs/319150721

/home/travis/miniconda3/envs/pandas/lib/python3.5/site-packages/pandas/tests/io/conftest.py:56: FileNotFoundError

=================================== FAILURES ===================================

 TestCommonIOCapabilities.test_read_fspath_all[reader4-feather-/home/travis/miniconda3/envs/pandas/lib/python3.5/site-packages/pandas/tests/io/data/feather-0_3_1.feather] 

[gw0] linux -- Python 3.5.4 /home/travis/miniconda3/envs/pandas/bin/python


self = <pandas.tests.io.test_common.TestCommonIOCapabilities object at 0x7f93b0cd67b8>

reader = <function read_feather at 0x7f93d86bb268>, module = 'feather'

path = '/home/travis/miniconda3/envs/pandas/lib/python3.5/site-packages/pandas/tests/io/data/feather-0_3_1.feather'


    @pytest.mark.parametrize('reader, module, path', [

        (pd.read_csv, 'os', os.path.join(HERE, 'data', 'iris.csv')),

        (pd.read_table, 'os', os.path.join(HERE, 'data', 'iris.csv')),

        (pd.read_fwf, 'os', os.path.join(HERE, 'data',

                                         'fixed_width_format.txt')),

        (pd.read_excel, 'xlrd', os.path.join(HERE, 'data', 'test1.xlsx')),

        (pd.read_feather, 'feather', os.path.join(HERE, 'data',

                                                  'feather-0_3_1.feather')),

        (pd.read_hdf, 'tables', os.path.join(HERE, 'data', 'legacy_hdf',

                                             'datetimetz_object.h5')),

        (pd.read_stata, 'os', os.path.join(HERE, 'data', 'stata10_115.dta')),

        (pd.read_sas, 'os', os.path.join(HERE, 'sas', 'data',

                                         'test1.sas7bdat')),

        (pd.read_json, 'os', os.path.join(HERE, 'json', 'data',

                                          'tsframe_v012.json')),

        (pd.read_msgpack, 'os', os.path.join(HERE, 'msgpack', 'data',

                                             'frame.mp')),

        (pd.read_pickle, 'os', os.path.join(HERE, 'data',

                                            'categorical_0_14_1.pickle')),

    ])

    def test_read_fspath_all(self, reader, module, path):

        pytest.importorskip(module)

    

        mypath = CustomFSPath(path)

>       result = reader(mypath)


/home/travis/miniconda3/envs/pandas/lib/python3.5/site-packages/pandas/tests/io/test_common.py:152: 

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

/home/travis/miniconda3/envs/pandas/lib/python3.5/site-packages/pandas/io/feather_format.py:112: in read_feather

    return feather.read_dataframe(path, nthreads=nthreads)

/home/travis/miniconda3/envs/pandas/lib/python3.5/site-packages/pyarrow/feather.py:143: in read_feather

    reader = FeatherReader(source)

/home/travis/miniconda3/envs/pandas/lib/python3.5/site-packages/pyarrow/feather.py:43: in __init__

    self.open(source)

feather.pxi:79: in pyarrow.lib.FeatherReader.open

    ???

io.pxi:622: in pyarrow.lib.get_reader

    ???

io.pxi:411: in pyarrow.lib.memory_map

    ???

io.pxi:390: in pyarrow.lib.MemoryMappedFile._open

    ???

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 


>   ???

E   pyarrow.lib.ArrowIOError: IOError: Failed to open file: /home/travis/miniconda3/envs/pandas/lib/python3.5/site-packages/pandas/tests/io/data/feather-0_3_1.feather


error.pxi:60: ArrowIOError

@jreback jreback added the Testing pandas testing functions or related to the test suite label Dec 20, 2017
@jreback jreback added this to the 0.22.0 milestone Dec 20, 2017
jreback added a commit to jreback/pandas that referenced this issue Dec 20, 2017
@jreback jreback reopened this Dec 20, 2017
@WillAyd
Copy link
Member

WillAyd commented Dec 21, 2017

I noticed that the fixture for the io tests does not make use of os.path.abspath whereas the tm.get_data_path function does. Perhaps using abspath on the former here could resolve?

HERE = os.path.dirname(__file__)

base_dir = os.path.abspath(os.path.dirname(filename))

jreback added a commit to jreback/pandas that referenced this issue Dec 21, 2017
CI: move 3.5 conda build to allowed_failures

closes pandas-dev#18870 for abspath
@jreback
Copy link
Contributor Author

jreback commented Dec 21, 2017

thank @WillAyd I made that change. Though this is still failing, but only on master. Not really sure what the problem is, but moved this build out of the main matrix for now. Its not very easy to test because it only fails on master and not on a fork. very weird.

@jreback
Copy link
Contributor Author

jreback commented Dec 29, 2017

closed via #18990

this is a travis bug: # travis-ci/travis-ci#8920 (comment)

fixes curtesy of @matthew-brett

@jreback jreback closed this as completed Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants