Skip to content

pytest.skip not working inside context manager? #18733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue Dec 11, 2017 · 2 comments
Closed

pytest.skip not working inside context manager? #18733

jbrockmendel opened this issue Dec 11, 2017 · 2 comments

Comments

@jbrockmendel
Copy link
Member

#18709 implements tests that uses tm.set_timezone context manager. set_timezone begins with:

    if is_platform_windows():
        import pytest
        pytest.skip("timezone setting not supported on windows")

But that apparently isn't raising as expected: https://ci.appveyor.com/project/pandas-dev/pandas/build/1.0.7947/job/2fadgp6te7e95ysc

@WillAyd
Copy link
Member

WillAyd commented Dec 11, 2017

We may have conflicting development. I removed this from the context manager in #18693 and replaced it with a decorator in the functions where it was being used.

I didn't your branch of revert_today having merged in my changes so I'm a little surprised to see the failure there but wanted to call that out nonetheless

@jbrockmendel
Copy link
Member Author

That would explain it, thanks. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants