We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related: #17876, #17734
In tslib._localize_tso there are 4 of blocks of the form:
tslib._localize_tso
if obj.value != NPY_NAT: pandas_datetime_to_datetimestruct(obj.value + delta, PANDAS_FR_ns, &obj.dts) else: pandas_datetime_to_datetimestruct(obj.value, PANDAS_FR_ns, &obj.dts)
But in the case where obj.value == NPY_NAT, can't we skip the call to pandas_datetime_to_datetimestruct because we're going to end up with NaT anyway?
obj.value == NPY_NAT
pandas_datetime_to_datetimestruct
NaT
The text was updated successfully, but these errors were encountered:
@jbrockmendel : There's one way to find out: remove the calls and run the tests 😄
Sorry, something went wrong.
Doesn't cause any test failures; kind of hoping for outside confirmation though.
This can be fixed in a follow-up after #17875 is closed
Move normalization funcs up to conversion (#18086)
9e3ad63
closes #17944
Move normalization funcs up to conversion (pandas-dev#18086)
358056b
closes pandas-dev#17944
Successfully merging a pull request may close this issue.
Related: #17876, #17734
In
tslib._localize_tso
there are 4 of blocks of the form:But in the case where
obj.value == NPY_NAT
, can't we skip the call topandas_datetime_to_datetimestruct
because we're going to end up withNaT
anyway?The text was updated successfully, but these errors were encountered: