Skip to content

DOC: Instructions for generate_legacy_storage_files #17721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Sep 29, 2017 · 2 comments · Fixed by #17733
Closed

DOC: Instructions for generate_legacy_storage_files #17721

jbrockmendel opened this issue Sep 29, 2017 · 2 comments · Fixed by #17733
Labels
Compat pandas objects compatability with Numpy or Python functions Testing pandas testing functions or related to the test suite
Milestone
0.21.0

Comments

@jbrockmendel
Copy link
Member

The usage instructions at the top of tests.io.test_pickle are inaccurate. Maybe something in contributing docs?
@sinhrks sinhrks added Compat pandas objects compatability with Numpy or Python functions Testing pandas testing functions or related to the test suite labels Sep 29, 2017
@sinhrks
Copy link
Member

sinhrks commented Sep 29, 2017

I think the issue should be solved by fixing generate_legacy_storage_files.py, but it's nice to add a document related to this.

jreback added a commit to jreback/pandas that referenced this issue Oct 1, 2017
@jreback
TST: add backward compat for offset testing for pickles
70f39b8 
closes pandas-dev#17721
@jreback jreback mentioned this issue Oct 1, 2017
Merged
@jreback
Copy link
Contributor

jreback commented Oct 1, 2017

see #17733, not averse to adding to contributing.rst, but this is a rather specific topic which doesn't come up all that often. The in-file documentation should be enough.

@jreback jreback added this to the 0.21.0 milestone Oct 1, 2017
jreback added a commit that referenced this issue Oct 1, 2017
@jreback
TST: add backward compat for offset testing for pickles (#17733)
408ecd2 
closes #17721
alanbato pushed a commit to alanbato/pandas that referenced this issue Nov 10, 2017
@jreback @alanbato
TST: add backward compat for offset testing for pickles (pandas-dev#1…
2b6148d 
…7733)

closes pandas-dev#17721
No-Stream pushed a commit to No-Stream/pandas that referenced this issue Nov 28, 2017
@jreback @No-Stream
TST: add backward compat for offset testing for pickles (pandas-dev#1…
b8ab160 
…7733)

closes pandas-dev#17721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

TST: add backward compat for offset testing for pickles jreback/pandas
3 participants
@jreback @sinhrks @jbrockmendel