-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
API: Deprecate Categorical fastpath argument #17562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
API Design
Categorical
Categorical Data Type
Deprecate
Functionality to remove in pandas
good first issue
Comments
Merged
Hi, I would like to work on this. |
Cool. The argument is [here](
https://github.com/pandas-dev/pandas/blob/7e159aeec1d5d2e79311ca688c0e594f0fd5f709/pandas/core/categorical.py#L245).
You'll want to warn when it's used, and tell people to use a
CategoricalDtype.
The trickier part will be finding all the places the argument is currently
used, and pass or construct an instance of a `CategoricalDtype` there
instead.
…On Thu, Oct 12, 2017 at 2:08 AM, Asish Panda ***@***.***> wrote:
Hi, I would like to work on this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17562 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIiQwSO7R03Cv9xpBjHPBzHw87Wbaks5srbrSgaJpZM4PaMOS>
.
|
1 task
6 tasks
closing in favor of #20110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API Design
Categorical
Categorical Data Type
Deprecate
Functionality to remove in pandas
good first issue
After #16015 the
fastpath
argument to the Categorical constructor is unnecessary since you can skip the categorical validation by passing in aCategoricalDtype
.lThe text was updated successfully, but these errors were encountered: