-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
to_datetime should support ISO week year #16607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
sure could be added. pull-requests are welcome. |
@jreback can you help me start working on this pull request? Like where to look to fix it? |
The relevant part should be in A good ref impl is |
@buyology Could I be assigned this task so that I can work on its pull request? |
@rosygupta feel free to work on this :-) |
@buyology This will be my first attempt to make a PR here. Do you suggest if this would be the right task to take on ? |
@rosygupta it involves some |
@buyology Seems achievable. Where do I look for the tests for this particular piece to check my code? |
@rosygupta this is a new feature request, so there aren't existing tests for it. Similar tests to what you would need to add are in https://github.com/pandas-dev/pandas/blob/73930c58e8eac4031608bb8c4bf624d77e1d1dcb/pandas/tests/indexes/datetimes/test_tools.py |
Hey, I'm not sure why tests of all classes are not being executed when testing. Only 6 classes being executed. Can someone clear out? |
@buyology @TomAugspurger Pulled a PR. Need some guidance. |
Hey I'm curious what's happening with this issue. I took a look at the referenced PR @rosygupta made and it looks like the PR fixes the issue, just needs to be rebased / fix any merge conflicts now? Any update into looking to get it merged in? |
you are welcome to do this |
Sure I can tackle this. |
So the datetime code has been moved out of |
to_datetime
does not currently seem to supportISO week year
likestrptime
does:pandas: 0.20.1
pytest: 3.1.0
pip: 9.0.1
setuptools: 28.8.0
Cython: 0.25.2
numpy: 1.12.1
scipy: 0.19.0
xarray: None
IPython: 6.0.0
sphinx: None
patsy: 0.4.1
dateutil: 2.6.0
pytz: 2017.2
blosc: None
bottleneck: None
tables: 3.4.2
numexpr: 2.6.2
feather: None
matplotlib: 2.0.2
openpyxl: None
xlrd: None
xlwt: None
xlsxwriter: None
lxml: None
bs4: None
html5lib: 0.999999999
sqlalchemy: 1.1.10
pymysql: None
psycopg2: 2.7.1 (dt dec pq3 ext lo64)
jinja2: 2.9.6
s3fs: None
pandas_gbq: None
pandas_datareader: None
The text was updated successfully, but these errors were encountered: