Skip to content

0.20.0 gratuitously breaks backwards compatibility #16138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhirschfeld opened this issue Apr 26, 2017 · 5 comments
Closed

0.20.0 gratuitously breaks backwards compatibility #16138

dhirschfeld opened this issue Apr 26, 2017 · 5 comments
Labels
API Design
Milestone
0.20.0

Comments

@dhirschfeld
Copy link
Contributor

PR #15998 removed the pandas.types module which AFAICT wasn't deprecated.

This breaks 3rd party libraries such as dask without giving them any warning or time to adjust to the new api.

IMHO a shim should be put in place with a deprecation warning to give 3rd party libraries a chance to adjust to the new api
dhirschfeld pushed a commit to dhirschfeld/pandas that referenced this issue Apr 26, 2017
Add shim modules with deprecation warnings to ensure backward compati…
2cf1f61 
…bility

The following shim modules are included:
  - `pandas.computation`
  - `pandas.tools.hashing`
  - `pandas.types`

Fixes pandas-dev#16138
dhirschfeld pushed a commit to dhirschfeld/pandas that referenced this issue Apr 26, 2017
Add shim modules with deprecation warnings to ensure backward compati…
7acc233 
…bility

The following shim modules are included:
  - `pandas.computation`
  - `pandas.tools.hashing`
  - `pandas.types`

Fixes pandas-dev#16138
@dhirschfeld dhirschfeld mentioned this issue Apr 26, 2017
Closed
@jreback
Copy link
Contributor

jreback commented Apr 26, 2017 •
edited
Loading

pandas.types was never public
dask is already compat (i fixed the latest)

@dhirschfeld
Copy link
Contributor Author

In python private modules are denoted by a leading underscore so by that definition it wasn't private and if it was supposed to be was there ever any way for anyone to be able to tell that?

@dhirschfeld
Copy link
Contributor Author

dask is only one such library which will break without warning

@jreback
Copy link
Contributor

jreback commented Apr 26, 2017

dask has already been fixed
they explicitly relied on some unstable apis and were willing to accept the risk
anything else is not going to be deprecated
the whatsnew is very clear

@dhirschfeld dhirschfeld mentioned this issue Apr 26, 2017
Closed
@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Apr 26, 2017
@jreback
Copy link
Contributor

jreback commented Apr 27, 2017

closed by 075eca1

@dhirschfeld if you find anything pls comment / open new issue.

@jreback jreback closed this as completed Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
3 participants
@dhirschfeld @jreback @jorisvandenbossche