-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG/BLD: pytest not a runtime dep #16065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
actually is there a reason we are doing an |
Ah, good catch, but the testing functions do not depend on pytest, so this should be solvable (although maybe a bit annoying to move all imports of pytest inline ..)
Because otherwise you cannot do |
Hmm, there is quite a lot of usage of pytest, so inline the import would be very annoying .. So if you remove the line in init, you get this:
but have to explicitly import it like |
@jreback do you know how this does work for |
I don't think this is a big deal. we explicity don't want to import the testings into the main namespace. It could be fixed to isolate, but maybe let's do that later. |
I think we could do this in testing, but it would require hiding the |
on master - now that we've exposed a testing api, need to wrap the import of pytest
The text was updated successfully, but these errors were encountered: