Skip to content

TST: full dtype tests for .drop_duplicates and .duplicated #15752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Mar 20, 2017 · 2 comments
Closed

TST: full dtype tests for .drop_duplicates and .duplicated #15752

jreback opened this issue Mar 20, 2017 · 2 comments
Labels
Dtype Conversions Unexpected or buggy dtype conversions duplicated duplicated, drop_duplicates Needs Tests Unit test(s) needed to prevent regressions

Comments

@jreback
Copy link
Contributor

jreback commented Mar 20, 2017 •
edited
Loading

#15738 (comment)
xref #15738

we exercise tests for .drop_duplicates & .duplicated in various places

  • for series -> pandas/tests/series/test_analytics.py
  • for dataframe -> pandas/test/frame/test_analytics.py
  • for index -> pandas/tests/test_base.py
  • datetimes -> pandas/tests//indexes/datetimes/test_ops.py
  • period -> pandas/tests//indexes/period/test_ops.py
  • categorical -> pandas/tests//test_categorical.py
  • timedelta -> pandas/tests//indexes/timedeltas/test_ops.py

I think we are a little light on the categorical ones (esp need to exercise with categories of int, datetime, timedelta, bool)

bool and a battery that covers all int & uint & float would be nice as well.

could certainly take multiple PR's to close this issue (if multiple people want to do this).
@jreback jreback added Difficulty Novice Dtype Conversions Unexpected or buggy dtype conversions Testing pandas testing functions or related to the test suite labels Mar 20, 2017
@jreback jreback modified the milestones: 0.20.0, Next Major Release Mar 20, 2017
@jamestran201
Copy link

Hi, could someone take a look at the test cases added in PR 17974? The test cases are for Series. If they are OK, I'll do the same to the remaining tests.
#17974

jreback pushed a commit that referenced this issue Oct 31, 2017
@jamestran201-alt @jreback
TST: #15752 Add drop_duplicates tests for uint, float and bool for Se…
4578a03 
…ries (#17974)
GuessWhoSamFoo pushed a commit to GuessWhoSamFoo/pandas that referenced this issue Nov 1, 2017
@jamestran201-alt @GuessWhoSamFoo
TST: pandas-dev#15752 Add drop_duplicates tests for uint, float and b…
61d42bf 
…ool for Series (pandas-dev#17974)
jreback pushed a commit that referenced this issue Nov 6, 2017
@jamestran201-alt @jreback
TST: #15752 Add test_drop_duplicates for Categorical dtypes (#18072)
9c49e64
No-Stream pushed a commit to No-Stream/pandas that referenced this issue Nov 28, 2017
@jamestran201-alt @No-Stream
TST: pandas-dev#15752 Add drop_duplicates tests for uint, float and b…
8e11d13 
…ool for Series (pandas-dev#17974)
No-Stream pushed a commit to No-Stream/pandas that referenced this issue Nov 28, 2017
@jamestran201-alt @No-Stream
TST: pandas-dev#15752 Add test_drop_duplicates for Categorical dtypes (…
c94e5f0 
…pandas-dev#18072)
@mproszewska mproszewska mentioned this issue Mar 10, 2020
Merged
3 tasks
@JochenFromm JochenFromm mentioned this issue Mar 27, 2020
Closed
@simonjayhawkins simonjayhawkins added Needs Tests Unit test(s) needed to prevent regressions and removed Testing pandas testing functions or related to the test suite good first issue labels Apr 23, 2020
@mroeschke mroeschke added the duplicated duplicated, drop_duplicates label May 8, 2021
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@mroeschke
Copy link
Member

I think we have testing for this now so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dtype Conversions Unexpected or buggy dtype conversions duplicated duplicated, drop_duplicates Needs Tests Unit test(s) needed to prevent regressions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jreback @TomAugspurger @jbrockmendel @mroeschke @simonjayhawkins @jamestran201