Skip to content

Broken link in cookbook for read_csv #15605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
memilanuk opened this issue Mar 7, 2017 · 4 comments
Closed

Broken link in cookbook for read_csv #15605

memilanuk opened this issue Mar 7, 2017 · 4 comments
Labels
Docs
Milestone
0.20.0

Comments

@memilanuk
Copy link

The second link in the section http://pandas.pydata.org/pandas-docs/stable/cookbook.html#csv
is broken.

I.e. the link read_csv in action is supposed to go to Wes McKinney's blog, but returns a 404 error.

A cursory look at said blog didn't result in anything jumping out at me as far as what should be the correct entry to link to.
@jreback
Copy link
Contributor

jreback commented Mar 7, 2017

@wesm did this change? http://wesmckinney.com/blog/?p=635

@jreback jreback added the Docs label Mar 7, 2017
@wesm
Copy link
Member

wesm commented Mar 9, 2017

Yeah, i migrated to pelican. think tha tlink may be http://wesmckinney.com/blog/update-on-upcoming-pandas-v0-10-new-file-parser-other-performance-wins/

lorenzocestaro added a commit to lorenzocestaro/pandas that referenced this issue Mar 17, 2017
@lorenzocestaro
Update broken link in cookbook pandas-dev#15605
5314a99
lorenzocestaro added a commit to lorenzocestaro/pandas that referenced this issue Mar 17, 2017
@lorenzocestaro
DOC: Update broken link in cookbook.rst pandas-dev#15605
006eefa
@lorenzocestaro
Copy link
Contributor

Hi guys, this is my first attempt to contribute to an open source project. I have a branch ready with the fix: I changed the broken link with the one provided by @wesm.
This is the commit with the change on my fork.

I'd like to know if it is ok if I go ahead and submit a PR, also let me know if there is something else I should do before opening the PR (tests, builds, ...).
Thanks!

@jreback
Copy link
Contributor

jreback commented Mar 17, 2017

nope, go ahead an make a PR

@jreback jreback added this to the 0.20.0 milestone Mar 17, 2017
@lorenzocestaro lorenzocestaro mentioned this issue Mar 17, 2017
Closed
4 tasks
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@lorenzocestaro @AnkurDedania
DOC: Update broken link in cookbook.rst pandas-dev#15605
66829d7 
closes pandas-dev#15605

Author: Lorenzo Cestaro <[email protected]>

Closes pandas-dev#15720 from LorenzoCestaro/fix-15605 and squashes the following commits:

006eefa [Lorenzo Cestaro] DOC: Update broken link in cookbook.rst pandas-dev#15605
mattip pushed a commit to mattip/pandas that referenced this issue Apr 3, 2017
@lorenzocestaro @mattip
DOC: Update broken link in cookbook.rst pandas-dev#15605
c45d23a 
closes pandas-dev#15605

Author: Lorenzo Cestaro <[email protected]>

Closes pandas-dev#15720 from LorenzoCestaro/fix-15605 and squashes the following commits:

006eefa [Lorenzo Cestaro] DOC: Update broken link in cookbook.rst pandas-dev#15605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

DOC: Update broken link in cookbook.rst #15605 lorenzocestaro/pandas
5 participants
@wesm @jreback @jorisvandenbossche @memilanuk @lorenzocestaro