Skip to content

DOC: Why do we have two README's for contributing? #15349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gfyoung opened this issue Feb 8, 2017 · 10 comments
Closed

DOC: Why do we have two README's for contributing? #15349

gfyoung opened this issue Feb 8, 2017 · 10 comments
Labels
Milestone

Comments

@gfyoung
Copy link
Member

gfyoung commented Feb 8, 2017

This one under the documentation folder here and this one under the .github folder here.

I think we should just have one point to the other to avoid having to maintain it in two different places.

@jreback
Copy link
Contributor

jreback commented Feb 8, 2017

I think you have a typo in the links (they are the same).

In any event, the canonical contributing guide is actually in the docs: http://pandas.pydata.org/pandas-docs/stable/contributing.html, but github has this 'feature' where they have a CONTRIBUTING.md. Our docs are .rst so this is problem.

maybe best is to change .github/CONTRIBUTING.md to just point directly to the docs.

@jreback
Copy link
Contributor

jreback commented Feb 8, 2017

though maybe the .github/CONTRIBUTING.md is just a rendered version of the docs.

We had a discussion about this a while back but I don't remember.

@jorisvandenbossche ?

@jorisvandenbossche
Copy link
Member

As far as I know, the one just a conversion of the other (so the .github/CONTRIBUTING.md should never be updated directly). We just keep forgetting that :-)

But, it is actually stated in the same docs .. See the note in http://pandas.pydata.org/pandas-docs/stable/contributing.html#about-the-pandas-documentation

@jorisvandenbossche
Copy link
Member

We also have a wiki page about this: https://github.com/pandas-dev/pandas/wiki/Regenerating-CONTRIBUTING.md

I don't feel strongly between the current situation or just putting a link in the contributing.md file to the docs

@gfyoung
Copy link
Member Author

gfyoung commented Feb 8, 2017

@jreback : Good catch on the links. I updated them. In any case, I'm perfectly fine with just linking the CONTRIBUTING.md to the .rst version. It seems easier to maintain. How about that?

@jreback
Copy link
Contributor

jreback commented Feb 8, 2017

I don't think you can do that. github only renders the .md. I think the current soln is pretty decent actually.

@gfyoung
Copy link
Member Author

gfyoung commented Feb 8, 2017

That's not what I meant. I meant we should just say, "Go read the canonical docs" and provide the link to the file, that's all.

@jreback
Copy link
Contributor

jreback commented Feb 8, 2017

@jorisvandenbossche ?

@gfyoung
Copy link
Member Author

gfyoung commented Feb 14, 2017

@jorisvandenbossche : Thoughts on my proposal above?

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Feb 14, 2017

I would be fine with a link to the main contributing docs, instead of having a copy of the full content (can't directly remember the reason why we originally did it like this).

But, I would do a bit more than just linking. Something like a very short summary, and linking to some different parts of the contributing docs.
For example directing people who want to submit a bug to the section on how to report an issue, and for people making a PR a checklist or link to checklist in the contributing docs (seems we actually don't have a good overview of what we expect currently).

gfyoung added a commit to forking-repos/pandas that referenced this issue Feb 18, 2017
Previously, we were trying to maintain two different copies of the documentation, one in the ".github" directory, and the other in the "docs/," which just imposes greater maintenance burden in the long-run.  We now use the ".github" to refer to different portions of the "docs/" version with short summaries for ease of navigation.

Closes pandas-devgh-15349.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Feb 18, 2017
Previously, we were trying to maintain two different copies of the documentation, one in the ".github" directory, and the other in the "docs/," which just imposes greater maintenance burden in the long-run.  We now use the ".github" to refer to different portions of the "docs/" version with short summaries for ease of navigation.

Closes pandas-devgh-15349.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Feb 20, 2017
Previously, we were trying to maintain two different copies of the documentation, one in the ".github" directory, and the other in the "docs/," which just imposes greater maintenance burden in the long-run.  We now use the ".github" to refer to different portions of the "docs/" version with short summaries for ease of navigation.

Closes pandas-devgh-15349.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Feb 21, 2017
Previously, we were trying to maintain two different copies of the documentation, one in the ".github" directory, and the other in the "docs/," which just imposes greater maintenance burden in the long-run.  We now use the ".github" to refer to different portions of the "docs/" version with short summaries for ease of navigation.

Closes pandas-devgh-15349.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Feb 21, 2017
Previously, we were trying to maintain two different copies of the documentation, one in the ".github" directory, and the other in the "docs/," which just imposes greater maintenance burden in the long-run.  We now use the ".github" to refer to different portions of the "docs/" version with short summaries for ease of navigation.

Closes pandas-devgh-15349.

[ci skip]
jorisvandenbossche pushed a commit that referenced this issue Feb 21, 2017
Previously, we were trying to maintain two different copies of the documentation, one in the ".github" directory, and the other in the "docs/," which just imposes greater maintenance burden in the long-run.  We now use the ".github" to refer to different portions of the "docs/" version with short summaries for ease of navigation.

Closes gh-15349.
@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Feb 21, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
Previously, we were trying to maintain two different copies of the documentation, one in the ".github" directory, and the other in the "docs/," which just imposes greater maintenance burden in the long-run.  We now use the ".github" to refer to different portions of the "docs/" version with short summaries for ease of navigation.

Closes pandas-devgh-15349.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants