Skip to content

BLD: numpy-dev causing some issues #15199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Jan 23, 2017 · 3 comments
Closed

BLD: numpy-dev causing some issues #15199

jreback opened this issue Jan 23, 2017 · 3 comments
Labels
Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Jan 23, 2017

https://travis-ci.org/pandas-dev/pandas/jobs/194558937

numpy/numpy#8279 was just merged, which broke our tests

:>
@jreback jreback added Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions labels Jan 23, 2017
@jreback jreback added this to the 0.20.0 milestone Jan 23, 2017
@jreback
Copy link
Contributor Author

jreback commented Jan 23, 2017

cc @jcrist

@jcrist
Copy link
Contributor

jcrist commented Jan 23, 2017

Looks like the issue is this line: https://github.com/pandas-dev/pandas/blob/master/pandas/core/ops.py#L453.

Before that numpy PR, that would always evaluate lib.infer_dtype, since bool(scalar_dtype) was always False.

@jreback
Copy link
Contributor Author

jreback commented Jan 23, 2017

yep, going to put a patch in shortly.

jreback added a commit to jreback/pandas that referenced this issue Jan 23, 2017
@jreback
COMPAT: don't rely on dtype being False after numpy >= 1.13
600e7f9 
closes pandas-dev#15199
@jreback jreback mentioned this issue Jan 23, 2017
Closed
jreback added a commit to jreback/pandas that referenced this issue Jan 23, 2017
@jreback
COMPAT: numpy-dev compat on bool(dtype) change
69f3fa4 
xref numpy/numpy#8279

closes pandas-dev#15199
jreback added a commit to jreback/pandas that referenced this issue Jan 24, 2017
@jreback
COMPAT: numpy-dev compat on bool(dtype) change
935fa11 
This is >= 1.13

xref numpy/numpy#8279

closes pandas-dev#15199
jreback added a commit to jreback/pandas that referenced this issue Jan 24, 2017
@jreback
COMPAT: numpy-dev compat on bool(dtype) change
49feb15 
This is >= 1.13

xref numpy/numpy#8279

closes pandas-dev#15199
jreback added a commit to jreback/pandas that referenced this issue Jan 24, 2017
@jreback
COMPAT: numpy-dev compat on bool(dtype) change
5475db3 
This is >= 1.13

xref numpy/numpy#8279

closes pandas-dev#15199
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@jreback @AnkurDedania
COMPAT: don't rely on dtype being False after numpy >= 1.13
051777d 
closes pandas-dev#15199

Author: Jeff Reback <[email protected]>

Closes pandas-dev#15200 from jreback/numpy-dev and squashes the following commits:

53d663e [Jeff Reback] BLD: pull wheel for numpy builds
5475db3 [Jeff Reback] COMPAT: numpy-dev compat on bool(dtype) change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

COMPAT: don't rely on dtype being False after numpy >= 1.13 jreback/pandas
2 participants
@jreback @jcrist