Skip to content

CI: invalidate cache when .pxi.in only changes #15154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Jan 18, 2017 · 4 comments · Fixed by #15159
Closed

CI: invalidate cache when .pxi.in only changes #15154

jreback opened this issue Jan 18, 2017 · 4 comments · Fixed by #15159
Labels
CI Continuous Integration
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Jan 18, 2017

In the following, only the .pxi.in were changed and setup.py correctly has dependencies on these, so local building is fine. However, on travis, the cython cache does not seem to be invalidation (and I had to resort to manually clearing it).

similar to my comment: #14937 (comment)

happened again on merging: #15139, see: https://travis-ci.org/pandas-dev/pandas/jobs/193092807
@jreback jreback added the CI Continuous Integration label Jan 18, 2017
@jreback jreback added this to the 0.20.0 milestone Jan 18, 2017
@jreback
Copy link
Contributor Author

jreback commented Jan 18, 2017

any ideas

cc @gfyoung
@chris-b1

@chris-b1
Copy link
Contributor

It's probably the same solution from #14363 (which was pxd) - adding pyx.in to those ci scripts.

@jreback
Copy link
Contributor Author

jreback commented Jan 18, 2017

ahh that makes sense.

@gfyoung
Copy link
Member

gfyoung commented Jan 18, 2017

I wonder if you could log the timestamps and see what Travis is getting on the files. We have the logic to update those files in the setup, but it's not firing.

jreback added a commit to jreback/pandas that referenced this issue Jan 19, 2017
@jreback
CI: add .pxi.in to build caching
1773ce6 
closes pandas-dev#15154
@jreback jreback mentioned this issue Jan 19, 2017
Merged
jreback added a commit that referenced this issue Jan 19, 2017
@jreback
CI: add .pxi.in to build caching (#15159)
684c4d5 
closes #15154
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@jreback @AnkurDedania
CI: add .pxi.in to build caching (pandas-dev#15159)
c6b6ea7 
closes pandas-dev#15154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

CI: add .pxi.in to build caching jreback/pandas
3 participants
@jreback @chris-b1 @gfyoung