Skip to content

ERR: No Error when values argument in pivot_table is not in df.columns #14938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdemulde opened this issue Dec 21, 2016 · 2 comments · Fixed by #14965
Closed

ERR: No Error when values argument in pivot_table is not in df.columns #14938

cdemulde opened this issue Dec 21, 2016 · 2 comments · Fixed by #14965
Labels
Error Reporting Incorrect or improved errors from pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Milestone

Comments

@cdemulde
Copy link
Contributor

Code Sample

import pandas as pd

test = pd.DataFrame({'Date':pd.date_range(pd.datetime.today(), periods=20,freq='M').tolist(),
'occurrenceID':range(0,20)})

test['year'] = test.set_index('eventDate').index.year
test['month'] = test.set_index('eventDate').index.month

heatmap_prep = test.reset_index().pivot_table(index='year',columns='month',values='occurenceID',aggfunc='count')

Problem description

The above code gives no error, while 'occurenceID' is not a dataframe column (as there is a typo, needs to be 'occurrenceID', with two r's). It just produces a dataframe with only an index. Maybe a KeyError should be thrown?

Output of pd.show_versions()

INSTALLED VERSIONS ------------------ commit: None python: 3.5.2.final.0 python-bits: 64 OS: Darwin OS-release: 14.5.0 machine: x86_64 processor: i386 byteorder: little LC_ALL: en_US.UTF-8 LANG: None LOCALE: en_US.UTF-8

pandas: 0.19.1
nose: None
pip: 9.0.1
setuptools: 32.1.0.post20161217
Cython: None
numpy: 1.11.2
scipy: 0.18.1
statsmodels: 0.6.1
xarray: None
IPython: 5.1.0
sphinx: None
patsy: 0.4.1
dateutil: 2.6.0
pytz: 2016.10
blosc: None
bottleneck: None
tables: None
numexpr: None
matplotlib: 1.5.3
openpyxl: None
xlrd: 1.0.0
xlwt: None
xlsxwriter: None
lxml: None
bs4: None
html5lib: None
httplib2: None
apiclient: None
sqlalchemy: None
pymysql: None
psycopg2: None
jinja2: 2.8
boto: None
pandas_datareader: None

@jreback
Copy link
Contributor

jreback commented Dec 21, 2016

yep, looks like a bug. These should be validated and a KeyError if not found (with a helpful message, iow which arg its coming from).

@jreback jreback added Difficulty Novice Error Reporting Incorrect or improved errors from pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Dec 21, 2016
@jreback jreback added this to the Next Major Release milestone Dec 21, 2016
@jreback jreback changed the title No Error when values argument in pivot_table is not in df.columns ERR: No Error when values argument in pivot_table is not in df.columns Dec 21, 2016
@Dr-Irv
Copy link
Contributor

Dr-Irv commented Dec 22, 2016

Looks like the KeyError is generated for when the index and columns arguments have a bad name. So it is only for values that there is an issue.

Dr-Irv added a commit to Dr-Irv/pandas that referenced this issue Dec 22, 2016
Dr-Irv added a commit to Dr-Irv/pandas that referenced this issue Dec 22, 2016
@jreback jreback modified the milestones: 0.20.0, Next Major Release Dec 23, 2016
Dr-Irv added a commit to Dr-Irv/pandas that referenced this issue Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants