Skip to content

TST: reorg groupby tests #14813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Dec 6, 2016 · 3 comments
Closed

TST: reorg groupby tests #14813

jreback opened this issue Dec 6, 2016 · 3 comments
Labels
Groupby Testing pandas testing functions or related to the test suite
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Dec 6, 2016

see suggestions here: #12607 (comment)

we have lots and lots of groupby tests and so getting pretty unweidly

so should reorg to a sub-dir setup like we have for other things

eg.

pandas/tests/groupby/.....
@jreback jreback added Groupby Testing pandas testing functions or related to the test suite labels Dec 6, 2016
@jreback jreback added this to the 0.20.0 milestone Dec 6, 2016
@aileronajay
Copy link
Contributor

@jreback so this change would involve relocating pandas/tests/test_groupby.py to the hierarchy pandas/tests/groupby/ and then breaking this file into other files (having tests of similar type)?

@jreback
Copy link
Contributor Author

jreback commented Dec 7, 2016

yes

@aileronajay
Copy link
Contributor

I have created this PR for the change, https://github.com/pandas-dev/pandas/pull/14817/commits

@aileronajay aileronajay mentioned this issue Dec 15, 2016
Closed
ischurov pushed a commit to ischurov/pandas that referenced this issue Dec 19, 2016
@aileronajay @ischurov
Groupby tests restructure
d04de4b 
closes pandas-dev#14813

Author: Ajay Saxena <[email protected]>

Closes pandas-dev#14817 from aileronajay/groupby_test_restructure and squashes the following commits:

860574d [Ajay Saxena] removed duplicate file
f6e1cda [Ajay Saxena] further split the tests
2cc0734 [Ajay Saxena] branched out the filter tests into a new file
ShaharBental pushed a commit to ShaharBental/pandas that referenced this issue Dec 26, 2016
@aileronajay @ShaharBental
Groupby tests restructure
994c19e 
closes pandas-dev#14813

Author: Ajay Saxena <[email protected]>

Closes pandas-dev#14817 from aileronajay/groupby_test_restructure and squashes the following commits:

860574d [Ajay Saxena] removed duplicate file
f6e1cda [Ajay Saxena] further split the tests
2cc0734 [Ajay Saxena] branched out the filter tests into a new file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

Groupby tests restructure aileronajay/pandas
2 participants
@jreback @aileronajay