Skip to content

TST: Some nose generator tests not running #14244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TomAugspurger opened this issue Sep 18, 2016 · 1 comment · Fixed by #14245
Closed

TST: Some nose generator tests not running #14244

TomAugspurger opened this issue Sep 18, 2016 · 1 comment · Fixed by #14245
Labels
Testing pandas testing functions or related to the test suite
Milestone

Comments

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Sep 18, 2016

e.g. pandas/computation/tests/test_eval.py:TestTypeCasting

nosetests pandas/computation/tests/test_eval.py:TestTypeCasting -vs -x --with-id
#431 test_binop_typecasting (pandas.computation.tests.test_eval.TestTypeCasting) ... ok

The obvious difference is that TestTypeCasting inherits from tm.TestCase. I thought nose was supposed to run these still, but apparently not.
EDIT: OK, nose doesn't support those:

Test classes that do not descend from unittest.TestCase may also include generator methods and class-level fixtures

This came up as part of verifying that #13856 isn't dropping any tests.

@TomAugspurger TomAugspurger added the Testing pandas testing functions or related to the test suite label Sep 18, 2016
@TomAugspurger
Copy link
Contributor Author

The good news is that the tests seem to pass :) I'd love to hear suggestions for how to search for other cases like this: Test classes inheriting from TestCase that have yield fixtures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant