Skip to content

keep consistency in calling to_csv either dataframe or series #14054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FrankMN opened this issue Aug 20, 2016 · 2 comments
Closed

keep consistency in calling to_csv either dataframe or series #14054

FrankMN opened this issue Aug 20, 2016 · 2 comments
Labels
IO CSV read_csv, to_csv
Milestone

Comments

@FrankMN
Copy link

FrankMN commented Aug 20, 2016

When I call to_csv of dataframe object, I am not required to explicitly set path parameter. The default one is None and will return a string. I thought the same thing for series object. This time the path parameter becomes explicitly required. I wonder if it is better to keep consistency between them.

@jreback
Copy link
Contributor

jreback commented Aug 20, 2016

Can u show an explicit example and pd.show_versions()

@jreback jreback added the IO CSV read_csv, to_csv label Aug 20, 2016
@gfyoung
Copy link
Member

gfyoung commented Aug 21, 2016

@jreback : There is no need. @FrankMN is referring to a signature mismatch, which you can see here and here. IMO we should default path=None for Series. This shouldn't be a breaking API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv
Projects
None yet
Development

No branches or pull requests

3 participants