Skip to content

DOC: doc/make.py uses IPython promptManager, which is removed from IPython 5.x #14003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
znmean opened this issue Aug 15, 2016 · 1 comment · Fixed by #14004
Closed

DOC: doc/make.py uses IPython promptManager, which is removed from IPython 5.x #14003

znmean opened this issue Aug 15, 2016 · 1 comment · Fixed by #14004
Labels

Comments

@znmean
Copy link
Contributor

znmean commented Aug 15, 2016

When I build document as described in contributing guideline below,
http://pandas-docs.github.io/pandas-docs-travis/contributing.html#building-the-documentation

it makes an error like this.

AttributeError: "'InteractiveShell' object has no attribute 'prompt_manager'"

This file uses removed class, from IPython 5.x (promptManager)
http://ipython.readthedocs.io/en/stable/whatsnew/version5.html

file: doc/sphinxext/ipython_sphinxext/ipython_directive.py

 805         if not self.state.document.current_source in self.seen_docs:
 806             self.shell.IP.history_manager.reset()
 807             self.shell.IP.execution_count = 1
 808             self.shell.IP.prompt_manager.width = 0
 809             self.seen_docs.add(self.state.document.current_source)
 810

output of pd.show_versions()

INSTALLED VERSIONS

commit: a0d05db
python: 3.5.2.final.0
python-bits: 64
OS: Darwin
OS-release: 15.3.0
machine: x86_64
processor: i386
byteorder: little
LC_ALL: None
LANG: ko_KR.UTF-8
LOCALE: ko_KR.UTF-8

pandas: 0.18.1+356.ga0d05db.dirty
nose: 1.3.7
pip: 8.1.2
setuptools: 25.1.6
Cython: 0.24.1
numpy: 1.11.1
scipy: 0.18.0
statsmodels: None
xarray: None
IPython: 5.1.0
sphinx: 1.4.1
patsy: None
dateutil: 2.5.3
pytz: 2016.6.1
blosc: None
bottleneck: None
tables: 3.2.3.1
numexpr: 2.6.1
matplotlib: 1.5.1
openpyxl: None
xlrd: None
xlwt: None
xlsxwriter: None
lxml: None
bs4: None
html5lib: None
httplib2: None
apiclient: None
sqlalchemy: None
pymysql: None
psycopg2: None
jinja2: 2.8
boto: None
pandas_datareader: None

I'm currently on pandas sprint at PyCon APAC, so i will send pull request today if possible.

@jorisvandenbossche
Copy link
Member

Thanks for reporting! We indeed made our sphinx tools not yet ipython 5 compatible. See also #13639

znmean added a commit to znmean/pandas that referenced this issue Aug 16, 2016
class promptManager has removed in IPython 5.x, but this file
still using that class, so it makes AttributeError.

close pandas-dev#14003
znmean added a commit to znmean/pandas that referenced this issue Aug 16, 2016
as it is not a user facing bug fix.

closes pandas-dev#14003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants