Skip to content

add methods to doc #1355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timmie opened this issue May 30, 2012 · 12 comments
Closed

add methods to doc #1355

timmie opened this issue May 30, 2012 · 12 comments

Comments

@timmie
Copy link
Contributor

timmie commented May 30, 2012

Please add a list of sampling methods to the docs at:

http://pandas.pydata.org/pandas-docs/dev/timeseries.html#up-and-downsampling

@changhiskhan
Copy link
Contributor

There are no separate upsample or downsample methods. Everything is done
through "resample" with various frequency aliases specified in the
documentation.

On Wed, May 30, 2012 at 5:18 PM, timmie <
[email protected]

wrote:

Please add a list of sampling methods to the docs at:

http://pandas.pydata.org/pandas-docs/dev/timeseries.html#up-and-downsampling


Reply to this email directly or view it on GitHub:
#1355

Chang She
Lambda Foundry http://www.lambdafoundry.com

@timmie
Copy link
Contributor Author

timmie commented May 30, 2012

OK, but how do I find out what I can use as how argument In [956]: ts.resample('D', how='mean')?

@changhiskhan
Copy link
Contributor

sum, mean, std, max, min, median, first, last, ohlc

note that you don't have to use strings at all if you supply your own method.

I'll add a note to the timeseries docs about this. Thanks

@timmie
Copy link
Contributor Author

timmie commented May 30, 2012

I also wondered where how='ohlc' comes from...

are you not using sphinx autodoc together with the docstrings?

@wesm
Copy link
Member

wesm commented May 30, 2012

OHLC is a pretty standard way to aggregate financial data (http://en.wikipedia.org/wiki/Open-high-low-close_chart)

@timmie
Copy link
Contributor Author

timmie commented May 30, 2012

yes, but wanted to suggest to point new users better to the possibilities that exists: which methods are available (standard, extended via numpy, etc.).

@wesm
Copy link
Member

wesm commented May 30, 2012

The docstring could use work. I'm hopeful that users (ahem) will help in this regard

@timmie
Copy link
Contributor Author

timmie commented May 30, 2012

Maybe such low hanging fruits could be tagged in the issues?
Then, user would have the possibility to find easy fixes.

@changhiskhan
Copy link
Contributor

Most "DOC" issues are similar low hanging fruit so I don't think it's necessary to have a distinct tag for this. We'd really welcome a pull request on docstrings :)

@timmie
Copy link
Contributor Author

timmie commented May 31, 2012

The docstring could use work. I'm hopeful that users (ahem) will help in this regard
So I gained / provoked a post on twitter by my questions.

I can give you hope: users just have to find an entry point: aplicability to own work, enough functionality and suffiecient documentation to know how to make use of it.

When Pandas was published first time (more or less together with the larry packages) it dd not see much applicability for my codig. Two things came together: the discontinuation of the scikits.timeseries and your ambitions to develop the best python time series library with the bridge to statistsics.
You can even not imagine the number applications and use case you would gain once this is more promoted in science and engineering.

Last but not least, the nature of open source shows that the interest and participation indeally also follow a leaning curve: first after publishing, you'll get mostly bug reports and feature request. Once the user base is there, people's contribution gets more colourful: some wirte docs, others new features, others just report bugs...

And pandas being a base libarary, many people will start building their libraries on top of it. together with statsmodels it's such a solid foundatdtion for data analysis, that other coders will then extend its capabilities domain specific (bioinformatics, earth observation, geoscience, etc.).

For my own libs (not yet published), I became quite good at docstring and Sphinx'ing. But first you have to understand how it works.

Also, I advice to add a link to the Numpy documentation standards to the contributors page.

Uff rather long here But I ain't got a blog or such...

@wesm
Copy link
Member

wesm commented May 31, 2012

I completely agree on all points. And don't worry, you aren't the first person to make tons of requests / suggestions but offer little help ;) Keep in mind how much coding work has gone into pandas over the last year and that I'm about 300 pages into a 400 page book on data analysis in Python. Plate rather full at the moment. Docs, etc will improve over time, and much faster if people who are not me or Chang get involved in the process-- we have to really be focused on shipping bug-free code and new features which is a much less accessible area of work for people to get involved (since grokking the pandas codebase, while not that complicated, is not a brief affair)

@timmie
Copy link
Contributor Author

timmie commented Jun 1, 2012

Most "DOC" issues are similar low hanging fruit so I don't think it's necessary to have a distinct tag for this. We'd really welcome a pull request on docstrings :)

I made also experience in the past that contributed where not added to the codebased due to

  • API changes
  • continous re-organisation of the docs by core developers

Consequently, I think #1370 could avoid such disapointment.

yarikoptic added a commit to neurodebian/pandas that referenced this issue Jun 21, 2012
* origin/master:
  DOC: string args to how in resample pandas-dev#1355
  BLD: turning isreleased to False
  DOC: release notes to close pandas-dev#1349
  ENH: Cython nancorr speeds up DataFrame.corr with method='pearson' by > 100x
  DOC: new parser functionality pandas-dev#1347
  DOC: another pass at release notes
  DOC: what's new
  DOC: release notes, what's new
  DOC: release notes and what's new
  BUG: parser with multiple date col and multiple index col pandas-dev#1344
  TST: additional tests for parsers and minor code cleanup
  ENH: KdePlot with DataFrame pandas-dev#1342. TST: frame kde and kde with logy pandas-dev#1341
  BUG: respect logy argument in KdePlot, close pandas-dev#1341
  BUG: set_xlim for time series plots pandas-dev#1339
  BUG: PeriodIndex.map tries to get super(DatetimIndex, self)
  BUG: fixed doc bug that caused latex build to fail
  DOC: cleaned up parser doc string to stop sphinx from complaining
  ENH: better error msg for fillna() with invalid method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants