Skip to content

BLD: py2.7 failing on perf hash changes (for windows) #13448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Jun 15, 2016 · 4 comments
Closed

BLD: py2.7 failing on perf hash changes (for windows) #13448

jreback opened this issue Jun 15, 2016 · 4 comments
Labels
Build Library building on various platforms Windows Windows OS
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Jun 15, 2016

xref #13436

so this is failing on windows py2.7 (3.5 works fine).

pandas\algos.c(113380) : warning C4244: '=' : conversion from 'int' to '__pyx_t_5numpy_float32_t', possible loss of data
pandas\algos.c(114441) : warning C4244: '=' : conversion from '__pyx_t_5numpy_int64_t' to '__pyx_t_5numpy_float64_t', possible loss of data
pandas\algos.c(114538) : warning C4244: '=' : conversion from '__pyx_t_5numpy_int64_t' to '__pyx_t_5numpy_float64_t', possible loss of data
pandas\algos.c(114647) : warning C4244: '=' : conversion from '__pyx_t_5numpy_int64_t' to '__pyx_t_5numpy_float64_t', possible loss of data
pandas\algos.c(114744) : warning C4244: '=' : conversion from '__pyx_t_5numpy_int64_t' to '__pyx_t_5numpy_float64_t', possible loss of data
pandas\algos.c(116387) : warning C4244: '=' : conversion from 'npy_double' to '__pyx_t_5numpy_float32_t', possible loss of data
pandas\algos.c(118081) : warning C4244: '=' : conversion from 'npy_double' to '__pyx_t_5numpy_float32_t', possible loss of data
pandas\algos.c(119587) : warning C4244: '=' : conversion from 'npy_double' to '__pyx_t_5numpy_float32_t', possible loss of data
pandas\algos.c(119609) : warning C4244: '/=' : conversion from 'double' to '__pyx_t_5numpy_float32_t', possible loss of data
pandas\algos.c(121324) : warning C4244: '=' : conversion from 'npy_double' to '__pyx_t_5numpy_float32_t', possible loss of data
pandas\algos.c(124112) : warning C4244: '=' : conversion from 'npy_double' to '__pyx_t_5numpy_float32_t', possible loss of data
pandas\algos.c(126309) : warning C4244: '=' : conversion from 'npy_double' to '__pyx_t_5numpy_float32_t', possible loss of data
pandas\algos.c(128960) : warning C4244: '=' : conversion from 'npy_double' to '__pyx_t_5numpy_float32_t', possible loss of data
pandas\algos.c(131798) : warning C4244: '=' : conversion from 'npy_double' to '__pyx_t_5numpy_float32_t', possible loss of data
pandas\algos.c(133366) : warning C4244: 'function' : conversion from 'Py_ssize_t' to 'int', possible loss of data
pandas\algos.c(134168) : warning C4244: '=' : conversion from 'long' to 'char', possible loss of data
pandas\algos.c(139210) : warning C4244: '=' : conversion from 'Py_ssize_t' to 'int', possible loss of data
pandas\algos.c(163983) : warning C4244: 'function' : conversion from 'Py_ssize_t' to 'int', possible loss of data
pandas\algos.c(164199) : warning C4244: 'function' : conversion from 'npy_int64' to 'int', possible loss of data
error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio 9.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2

would be ok with just having this change affect py3 instead

@jreback jreback added Build Library building on various platforms Windows Windows OS labels Jun 15, 2016
@jreback
Copy link
Contributor Author

jreback commented Jun 15, 2016

cc @chris-b1

@jreback jreback added this to the 0.18.2 milestone Jun 15, 2016
@jreback jreback changed the title BLD: py2.7 failing on perf hash changes BLD: py2.7 failing on perf hash changes (for windows) Jun 15, 2016
@chris-b1
Copy link
Contributor

I at least got a more helpful error message locally, I can take a look later. It might be preferable to keep this in py2 too, since I think it's a little faster than the py2 hash, and for consistency.

pandas/src/klib\khash_python.h(16) : error C2054: expected '(' to follow 'inline'
pandas/src/klib\khash_python.h(16) : error C2085: 'asint64' : not in formal parameter list
pandas/src/klib\khash_python.h(16) : error C2143: syntax error : missing ';' before '{'

@jreback
Copy link
Contributor Author

jreback commented Jun 15, 2016

yes I think that Py_ssize_t is 32-bits on windows is the issue. But I think for simplicity just make this for py3, then should be fine.

@chris-b1
Copy link
Contributor

Older MSVC is apparently weird about inline, it looks like all that needs to be done is replace it with the PANDAS_INLINE macro, which expands to __inline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms Windows Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants