Skip to content

The documentation around frequency strings is unclear #13160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mineo opened this issue May 12, 2016 · 11 comments
Closed

The documentation around frequency strings is unclear #13160

mineo opened this issue May 12, 2016 · 11 comments
Labels
Milestone

Comments

@mineo
Copy link
Contributor

mineo commented May 12, 2016

http://pandas.pydata.org/pandas-docs/stable/generated/pandas.DataFrame.rolling.html?highlight=rolling#pandas.DataFrame.rolling and various other places in the documentation talk about something called "frequency strings", however, there doesn't seem to be any explanation of what this term means anywhere. http://pandas.pydata.org/pandas-docs/stable/timeseries.html#dateoffset-objects mentions the term again without explaining it. From the few examples I found, I now think http://pandas.pydata.org/pandas-docs/stable/timeseries.html#offset-aliases (note that this is after the dateoffset objects in the documentation) is the complete list of frequency strings, but for some reason they're called "offset aliases" here. Are those the frequency strings? If not, where are they defined?

@sinhrks sinhrks added Docs Frequency DateOffsets labels May 12, 2016
@sinhrks
Copy link
Member

sinhrks commented May 12, 2016

I think another confusion is caused by legacy aliases. We've formally deprecated legacy offsets in 0.17 (#10951), thus 0.19 may be a good timing to re-organize the doc (including your point).

@jreback jreback added this to the 0.19.0 milestone May 13, 2016
@ckrapu
Copy link

ckrapu commented May 13, 2016

I'd like to take this for my first PR. Could it be assigned to me?

@jreback
Copy link
Contributor

jreback commented May 13, 2016

@ckrapu go ahead an submit a PR when you are ready.

@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.0 Jul 8, 2016
@sahildua2305
Copy link
Contributor

@ckrapu are you still working on this? If not, I'd like to work on this. Please let me know.

@ckrapu
Copy link

ckrapu commented Jul 12, 2016

Nope, all yours. I got stuck trying to build the docs and sort out what
actually needed to be edited. If you do work on it, I'd really like to see
what you end up doing, as a sort of tutorial.
On Jul 12, 2016 5:20 PM, "Sahil Dua" [email protected] wrote:

@ckrapu https://github.com/ckrapu are you still working on this? If
not, I'd like to work on this. Please let me know.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13160 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AKBR4ia-wV3-LxXts89gPTK3Pd5w9kwrks5qVAU4gaJpZM4IdYXW
.

@sahildua2305
Copy link
Contributor

Awesome!

@jreback can you please suggest some ideas about including the point mentioned by @mineo? One thing can be including the link to this explanation wherever frequency string is mentioned/used. Other approach I can think of is to bring the same explanation part in the beginning.

Am I thinking in the right direction?

@jreback
Copy link
Contributor

jreback commented Jul 12, 2016

sure u can include the link

@sahildua2305
Copy link
Contributor

@jreback I am not sure from where I can edit this page. I think that it's coming up from the Class documentation in window.py. Should I add additional note for the frequency strings here?

@jreback
Copy link
Contributor

jreback commented Jul 12, 2016

that page is the actual doc-string defined in window.py

docs themselves r in pandas/doc/source

@sahildua2305
Copy link
Contributor

Thanks! I'll submit the PR in a while.

@jorisvandenbossche
Copy link
Member

@ckrapu If you got stuck with building the docs, always welcome to specify what the problem was, so we can try to make contributing to the documentation as easy as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants