Skip to content

TST: Start using py.test #13097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
max-sixty opened this issue May 5, 2016 · 5 comments
Closed

TST: Start using py.test #13097

max-sixty opened this issue May 5, 2016 · 5 comments
Labels
Needs Discussion Requires discussion from core team before further action Testing pandas testing functions or related to the test suite
Milestone
0.20.0

Comments

@max-sixty
Copy link
Contributor

max-sixty commented May 5, 2016 •
edited by jreback
Loading

from #13091

Currently most of the tests pass with pytest, but there are 69 that don't. Most of these look like they're pickle or SQL / external resources issues.

pytest output here: https://gist.github.com/MaximilianR/225a071337e335ebdcc1d17637126126

So this does need a champion who could work through those issues. That's probably not me at the moment, but you have my moral support!

mpl is converting!
matplotlib/matplotlib#5405
@jreback jreback changed the title TEST: Start using py.test TST: Start using py.test May 5, 2016
@jreback jreback added Testing pandas testing functions or related to the test suite Needs Discussion Requires discussion from core team before further action labels May 5, 2016
@jreback jreback added this to the Next Major Release milestone May 5, 2016
@jreback
Copy link
Contributor

jreback commented May 5, 2016

those fails are because we abusing nose a bit to be more parameterized (by using yield).

@kawochen
Copy link
Contributor

kawochen commented May 5, 2016

Did you mean generative tests? pytest has a similar thing.

@jreback
Copy link
Contributor

jreback commented May 5, 2016

yes, but actually wouldn't do that. These really should be parameterized test in py.test. This was a hack in nose to get it to work.

@par2
Copy link

par2 commented May 9, 2016

I'd like to switch to pytests eventually, but 8/9 of my errors are related to pandas._testing.assert_almost_equal. Can this be fixed too?

@jreback
Copy link
Contributor

jreback commented May 9, 2016

@par2 need someone to work thru all of these issues.

@TomAugspurger TomAugspurger mentioned this issue Jul 31, 2016
Closed
4 tasks
@jreback jreback modified the milestones: 0.20.0, Next Major Release Feb 8, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this issue Mar 21, 2017
@TomAugspurger @AnkurDedania
TST: Use pytest
eaf2216 
closes pandas-dev#13097

Author: Tom Augspurger <[email protected]>

Closes pandas-dev#13856 from TomAugspurger/pytest and squashes the following commits:

59e2be9 [Tom Augspurger] NOSE_ARGS -> TEST_ARGS
03695aa [Tom Augspurger] TST: Remove disabled marks
42790ae [Tom Augspurger] TST: Remove test_multi.sh
40d7336 [Tom Augspurger] PKG: redo pd.test import
9ba1f12 [Tom Augspurger] TST: Skip if getlocale is None
14c447c [Tom Augspurger] TST: pd.test uses pytest
c4f6008 [Tom Augspurger] TST/CI: Use pytest
b268d89 [Tom Augspurger] TST: Change method to make reporting more standard
a638390 [Tom Augspurger] TST: Test consistency change
c8dc927 [Tom Augspurger] TST: Refactor to use setup_class
9b5f2b2 [Tom Augspurger] TST: Refactor sql test inheritance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Discussion Requires discussion from core team before further action Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
4 participants
@jreback @max-sixty @kawochen @par2