Import statements in period.pyx significantly impact performance

[rs2]

The following imports in pandas/src/period.pyx significantly impact performance when dealing with multiple Period objects. A quick win, guys.

    def __init__(self, value=None, freq=None, ordinal=None,
                 year=None, month=1, quarter=None, day=1,
                 hour=0, minute=0, second=0):
        from pandas.tseries import frequencies
        from pandas.tseries.frequencies import get_freq_code as _gfc

        # freq points to a tuple (base, mult);  base is one of the defined
        # periods such as A, Q, etc. Every five minutes would be, e.g.,
        # ('T', 5) but may be passed in as a string like '5T'

Just profile the code below and observe the number of times _find_and_load gets called:

import pandas as pd

for _ in range(1000):
    pd.Period('2015-04-26')

bfa8066 is the commit that has introduced the problem.

I will submit a pull request that rectifies the incorrect fix to the circular dependency.

[sinhrks]

Thanks for the catch. Moving some frequency related codes to offset.pyx is one idea (#11214).

[jreback]

so this is the same issue behind #11831

[rs2]

@jreback Correct. I'll submit a pull request after lunch. Tested the fix
locally and ran unit tests. It's all good.
On 15 Apr 2016 10:21 p.m., "Sinhrks" [email protected] wrote:

Thanks for the catch. Moving some frequency related codes to offset.pyx is
one idea (#11214 #11214).

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#12903 (comment)

[rs2]

See #12909

On Sat, Apr 16, 2016 at 11:26 AM, Paul A [email protected] wrote:

@jreback Correct. I'll submit a pull request after lunch. Tested the fix
locally and ran unit tests. It's all good.
On 15 Apr 2016 10:21 p.m., "Sinhrks" [email protected] wrote:

Thanks for the catch. Moving some frequency related codes to offset.pyx
is one idea (#11214 #11214).

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#12903 (comment)