-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
fromnumeric.py compatibility with GroupBy, Window, and tslib functions #12811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jreback : Adding timestamps and timedeltas as well to this issue given my question about |
With my initial
|
how so, I don't really care to be compat with numpy for anything beyond very basic stuff. pls show an example. |
Examples:
All I was thinking of doing was putting validation calls in the implementation, similar to what was done in my previous PR and nothing more than that. I'm also perfectly fine leaving them as is since |
|
ok that doesn't seem unreasonable |
Do we actually want something like |
@jorisvandenbossche : I'll leave that for you to debate with @jreback . To reiterate, I am perfectly fine either way. This is not as serious a compatibility issue as the previous one I raised in #12644. |
Expands compatibility with fromnumeric.py in tslib.pyx and puts checks in window.py, groupby.py, and resample.py to ensure that pandas functions such as 'mean' are not called via the numpy library. Closes pandas-devgh-12811.
In #12810, it was decided that compatibility for
groupby
(includingresample.py
) andwindow
functions would be left for a separate PR / discussion, which seems reasonable given how massive #12810 already is. This issue serves a reminder to tackle this after landing #12810, as it seems like this can be easily addressed afterwards.The text was updated successfully, but these errors were encountered: