Skip to content

COMPAT: dateutil 2.5.2 broke sometests #12730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Mar 29, 2016 · 0 comments · Fixed by #12731
Closed

COMPAT: dateutil 2.5.2 broke sometests #12730

jreback opened this issue Mar 29, 2016 · 0 comments · Fixed by #12731
Labels
Compat pandas objects compatability with Numpy or Python functions Datetime Datetime data dtype
Milestone
0.18.1

Comments

@jreback
Copy link
Contributor

jreback commented Mar 29, 2016

dateutil/dateutil#217 was fixed in 2.5.2
similar to fixes in #12613

so need to adjust our tests based on version >= 2.5.2 to handle the new behavior.
the OSX build uses pip to pick up the new version so currently is failing
the 3.5 build uses latest conda, so its still using 2.5.1

======================================================================
ERROR: test_parsers_dayfirst_yearfirst (pandas.tseries.tests.test_tslib.TestDatetimeParsingWrappers)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jreback/pandas/pandas/tseries/tests/test_tslib.py", line 608, in test_parsers_dayfirst_yearfirst
    yearfirst=yearfirst)
  File "/Users/jreback/pandas/pandas/tseries/tools.py", line 523, in parse_time_string
    yearfirst=yearfirst)
  File "pandas/tslib.pyx", line 1765, in pandas.tslib.parse_datetime_string_with_reso (pandas/tslib.c:32262)
    raise DateParseError(e)
DateParseError: month must be in 1..12
@jreback jreback added Datetime Datetime data dtype Difficulty Novice Compat pandas objects compatability with Numpy or Python functions labels Mar 29, 2016
@jreback jreback added this to the 0.18.1 milestone Mar 29, 2016
@jreback jreback mentioned this issue Mar 29, 2016
Merged
jreback added a commit to jreback/pandas that referenced this issue Mar 29, 2016
@jreback
COMPAT: compat for dateutil 2.5.0 and differing dayfirst=True & yearf…
845ff97 
…irst=True

closes pandas-dev#12730
closes pandas-dev#12731
@jorisvandenbossche jorisvandenbossche mentioned this issue Mar 29, 2016
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Datetime Datetime data dtype
Projects
None yet
Milestone
0.18.1
Development

Successfully merging a pull request may close this issue.

COMPAT: compat for dateutil 2.5.0 and differing dayfirst=True & yearf… jreback/pandas
1 participant
@jreback