Skip to content

ERR: csv parsing error consistency of exceptions #12665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Mar 18, 2016 · 10 comments · Fixed by #14479
Closed

ERR: csv parsing error consistency of exceptions #12665

jreback opened this issue Mar 18, 2016 · 10 comments · Fixed by #14479
Labels
Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Mar 18, 2016

xref #12551

a) change CParserError to an actual ValueError. this is used in a very small number of cases in the engine='c' parser. (in #12551 it will inherit from ValueError)

b) So we either change ALL ValueError to ParserError(ValueError) (e.g. a custom exception) and make the changes in both the engine='c' and engine='python'.
@jreback jreback added Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv labels Mar 18, 2016
@jreback jreback added this to the 0.19.0 milestone Mar 18, 2016
@jreback
Copy link
Contributor Author

jreback commented Mar 18, 2016

cc @gfyoung @jorisvandenbossche

thoughts?

@gfyoung
Copy link
Member

gfyoung commented Mar 18, 2016

xref #12506 as well

Hmmm...from a semantic point of view, I would prefer ParserError over the more generic ValueError. However, it does seem like converting everything to ParserError is going to break a lot more things compared to ValueError I'd imagine.

@gfyoung
Copy link
Member

gfyoung commented Apr 17, 2016 •
edited
Loading

@jreback : Does the merged #12506 handle this issue satisfactorily?

@jreback
Copy link
Contributor Author

jreback commented Apr 17, 2016

yes, ty.

closed by #12506

@jreback jreback closed this as completed Apr 17, 2016
@jreback jreback reopened this Apr 17, 2016
@jreback
Copy link
Contributor Author

jreback commented Apr 17, 2016

actually. What I eventually wanted was to make ALL parser exceptions the same, which is an API change.

@gfyoung
Copy link
Member

gfyoung commented Apr 17, 2016

By which you mean across both the CParser and the PythonParser or that they just always raise one exception whenever there is an error in the reading?

@jreback
Copy link
Contributor Author

jreback commented Apr 17, 2016

yes I think we need to have a single ParserException (which is just a ValueError). (and remove the CParserException moniker, that's why its an API change.

@gfyoung
Copy link
Member

gfyoung commented Apr 17, 2016

Okay, that makes sense. Just wanted to clarify!

gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 23, 2016
@gfyoung
API: Rename CParserError to ParserError.
3e89a37 
Closes pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 23, 2016
@gfyoung
API: Rename CParserError to ParserError.
cb53574 
Closes pandas-devgh-12665.
@gfyoung gfyoung mentioned this issue Oct 23, 2016
Merged
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 23, 2016
@gfyoung
API: Rename CParserError to ParserError.
19f626a 
Closes pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 24, 2016
@gfyoung
API: Deprecate CParserError in favor of ParserError.
7d3ddd3 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 24, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
07ef63d 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 24, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
c7d00f1 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 24, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
ed1fa3e 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 25, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
8cbafe4 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 25, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
3d2619e 
Partially resolves pandas-devgh-12665.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 26, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
0f4e4aa 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 26, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
1f5e769 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 27, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
542f398 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 27, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
f18f6c4 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 27, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
fb24c0f 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 28, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
02f36a3 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 30, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
85939a8 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Oct 31, 2016
@gfyoung
DEPR: Deprecate CParserError in favor of ParserError.
6395ffe 
Partially resolves pandas-devgh-12665.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 1, 2016
@gfyoung
API: Alias CParserError to ParserError.
74af4e7 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 2, 2016
@gfyoung
API: Alias CParserError to ParserError.
f74eee7 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 3, 2016
@gfyoung
API: Alias CParserError to ParserError.
51c3de6 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 4, 2016
@gfyoung
API: Alias CParserError to ParserError.
1c220f3 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 5, 2016
@gfyoung
API: Alias CParserError to ParserError.
26f6588 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 8, 2016
@gfyoung
API: Alias CParserError to ParserError.
2d00328 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 8, 2016
@gfyoung
API: Alias CParserError to ParserError.
0fc1ab1 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 9, 2016
@gfyoung
API: Alias CParserError to ParserError.
c3a7a87 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 9, 2016
@gfyoung
API: Alias CParserError to ParserError.
1bba421 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 10, 2016
@gfyoung
API: Alias CParserError to ParserError.
31ebd38 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 10, 2016
@gfyoung
API: Alias CParserError to ParserError.
4c17681 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 11, 2016
@gfyoung
API: Alias CParserError to ParserError.
d3d434e 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 12, 2016
@gfyoung
API: Alias CParserError to ParserError.
4481327 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 13, 2016
@gfyoung
API: Alias CParserError to ParserError.
70793ec 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.

[ci skip]
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 13, 2016
@gfyoung
API: Alias CParserError to ParserError.
751be9b 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 13, 2016
@gfyoung
API: Alias CParserError to ParserError.
d83c8df 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 13, 2016
@gfyoung
API: Alias CParserError to ParserError.
8d7f1b5 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 14, 2016
@gfyoung
API: Alias CParserError to ParserError.
78586fb 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 15, 2016
@gfyoung
API: Alias CParserError to ParserError.
9dd131d 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 16, 2016
@gfyoung
API: Alias CParserError to ParserError.
3b7bee6 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 17, 2016
@gfyoung
API: Alias CParserError to ParserError.
41cc041 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
gfyoung added a commit to forking-repos/pandas that referenced this issue Nov 18, 2016
@gfyoung
API: Rename CParserError to ParserError.
912668e 
Partially resolves pandas-devgh-12665. We will remove
CParserError in the future.
jorisvandenbossche pushed a commit that referenced this issue Nov 18, 2016
@gfyoung @jorisvandenbossche
API: Rename CParserError to ParserError (#14479)
c045e1d 
Partially resolves gh-12665. We will remove
CParserError in the future.
@jorisvandenbossche
Copy link
Member

@gfyoung You said this is only partially resolved by the merged PR?

@gfyoung
Copy link
Member

gfyoung commented Nov 18, 2016

@jorisvandenbossche : Hmm...not sure why I said that. Should just be resolves. Oh well. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv
Projects
None yet
Milestone
0.20.0
Development

Successfully merging a pull request may close this issue.

API: Rename CParserError to ParserError forking-repos/pandas
3 participants
@jreback @jorisvandenbossche @gfyoung