Skip to content

blacklist numexpr 2.4.4 #12489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsm054 opened this issue Feb 28, 2016 · 5 comments
Closed

blacklist numexpr 2.4.4 #12489

dsm054 opened this issue Feb 28, 2016 · 5 comments
Labels
Compat pandas objects compatability with Numpy or Python functions
Milestone

Comments

@dsm054
Copy link
Contributor

dsm054 commented Feb 28, 2016

Under some circumstances, numexpr 2.4.4 can lead to flaky output (see #12023 and links therein). This happened again once on SO in the last few days, and it's a suspect in another case.

[UPDATE: the suspect was convicted of the second crime as well!]

We should just refuse to work with 2.4.4, rather than leave the impression pandas is unstable, and require a later version as soon as we can. There are apparently still enough people out there with up-to-date pandas and out-of-date numexpr that a warning could probably help someone. Accordingly, after some discussion on gitter, it sounds like we should

(1) add a warning to the docs
(2) centralize the version check (right now both computation/eval and computation/expressions check the numexpr version)
(3) only allow numexpr if >= 2.1 and not == 2.4.4; otherwise, set _USE_NUMEXPR to False
(4) in the warning we raise, recommend upgrading from 2.4.4 because we can't easily prevent other dependencies from using it
(5) add a test to make sure that the presence of 2.4.4 disables _USE_NUMEXPR (say, by adding it to the requirements-3.4_SLOW).

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Feb 28, 2016
@jreback jreback added this to the 0.18.0 milestone Feb 28, 2016
jreback added a commit to jreback/pandas that referenced this issue Mar 3, 2016
@jreback jreback closed this as completed in 84781b4 Mar 3, 2016
@debboutr
Copy link

what is the recommended fix for this? roll back to 2.4.3 OR forward to 2.4.6 or 2.5???

@jreback
Copy link
Contributor

jreback commented Mar 29, 2016

either will work
newer fixes some threading issues so easiest to do that

@vgoklani
Copy link

vgoklani commented Jun 28, 2016

How do we remove this warning: "The installed version of numexpr 2.4.4 is not supported in pandas and will be not be used UserWarning)"

@TomAugspurger
Copy link
Contributor

@vgoklani you can upgrade numexpr, conda upgrade numexpr if you're using conda.

@vgoklani
Copy link

@TomAugspurger Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants