Skip to content

BLD: Travis dedup via webhooks #12438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kawochen opened this issue Feb 24, 2016 · 10 comments
Closed

BLD: Travis dedup via webhooks #12438

kawochen opened this issue Feb 24, 2016 · 10 comments
Labels
CI Continuous Integration

Comments

@kawochen
Copy link
Contributor

Came across this just now https://github.com/grosser/travis_dedup
It sounds like it cancels old builds on a PR. It works via github webhooks.

@jreback
Copy link
Contributor

jreback commented Feb 24, 2016

oh that looks nice. ok i'll try this when I have some time.

@jreback jreback added this to the 0.18.1 milestone Feb 24, 2016
@jreback jreback added the CI Continuous Integration label Feb 24, 2016
@jreback
Copy link
Contributor

jreback commented Mar 5, 2016

ok I setup this webhook, let's monitor and see if this works

@gliptak
Copy link
Contributor

gliptak commented Apr 11, 2016

@jreback I have seen builds cancelled for out-of-date (repushed) commits when working #12833

@jreback
Copy link
Contributor

jreback commented Apr 11, 2016

that was me :) sometimes I cancel the dups

@jreback jreback modified the milestones: 0.18.1, 0.18.2 Apr 26, 2016
@jorisvandenbossche jorisvandenbossche modified the milestones: Someday, 0.19.0 Aug 13, 2016
@jorisvandenbossche
Copy link
Member

For inspiration, there is a script in this PR on conda-forge to do something like this: conda-forge/staged-recipes#2257

@jreback
Copy link
Contributor

jreback commented Mar 22, 2017

that's nice will steal!

jreback added a commit to jreback/pandas that referenced this issue Mar 22, 2017
jreback added a commit to jreback/pandas that referenced this issue Mar 22, 2017
jreback added a commit to jreback/pandas that referenced this issue Mar 22, 2017
jreback added a commit to jreback/pandas that referenced this issue Mar 22, 2017
jreback added a commit to jreback/pandas that referenced this issue Mar 22, 2017
@jreback
Copy link
Contributor

jreback commented Mar 22, 2017

https://blog.travis-ci.com/2017-03-22-introducing-auto-cancellation

on the day we push this feature....hahah

@jorisvandenbossche
Copy link
Member

That's a timing :-)

Question is if they still run all jobs of a build once one job is started. Because if not, the script still has some use.

@jreback
Copy link
Contributor

jreback commented Mar 22, 2017

actual what they have is very nice
the second you push a new PR the original is completely cancelled

the script has to launch and it individually cancels - takes about 1 min per

@jreback
Copy link
Contributor

jreback commented Mar 22, 2017

and their feature allows cancellation on your own branch as well :>

mattip pushed a commit to mattip/pandas that referenced this issue Apr 3, 2017
closes pandas-dev#12438

Author: Jeff Reback <[email protected]>

Closes pandas-dev#15780 from jreback/dedupe and squashes the following commits:

64f217e [Jeff Reback] replace . by space
b6f2a62 [Jeff Reback] formatting
0c33d9b [Jeff Reback] tests commit
24f6ae6 [Jeff Reback] CI: fast finish travis builds for the same PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants