-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Clarify documentation on numexpr in eval / query #12008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
can you show This should fall back to use the python engine if |
Below is the output after I installed numexpr. This is all based on the latest miniconda2 version.
|
I just did a
|
ok, prob need some fallback logic then. you can have a look in I suspect this is skipped in testing now because since lmk. |
I reviewed
while
(I didn't find good references in the documentation on these above) |
oh I didn't realize we had another issue about this; was fixed here just recently. no need to clarify the docs as we do the auto fallback. |
#12867 is still applicable though |
So the
query
function callseval
under the hood, which ends up meaning that the function call ends failing with the following when numexpr is not present. This means that the default engine (numexpr) will lead to error on systems without having extra dependencies present.I see four solutions, which I list in increasing order of difficulty:
numexpr
dependency much clearer in the docstrings. Explicitly say that an ImportError will occur if you use the default arguments without having numexpr installed.edit It appears that option (3) is preferred here.
The text was updated successfully, but these errors were encountered: