Skip to content

ERR: between_time should raise on non-timelike objects #11818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Dec 11, 2015 · 1 comment
Closed

ERR: between_time should raise on non-timelike objects #11818

jreback opened this issue Dec 11, 2015 · 1 comment
Labels
Datetime Datetime data dtype Error Reporting Incorrect or improved errors from pandas
Milestone
0.18.0

Comments

@jreback
Copy link
Contributor

jreback commented Dec 11, 2015

from SO

so passing anything except time objects or strings should raise (might be a tad tricky as we don't have great time parsers, they all parse datetimelikes).

IIRC this was done for convenience at the time. But can lead to an unstatisfactory user experience.
@jreback jreback added Datetime Datetime data dtype Error Reporting Incorrect or improved errors from pandas labels Dec 11, 2015
@jreback jreback added this to the Next Major Release milestone Dec 11, 2015
@rockg rockg mentioned this issue Dec 12, 2015
Closed
@jreback jreback modified the milestones: 0.18.0, Next Major Release Dec 13, 2015
jreback pushed a commit that referenced this issue Jan 3, 2016
@rockg @jreback
ERR/ENH: between_time checks argument types and new to_time function, #…
9c71dbf 
…11818
@jreback
Copy link
Contributor Author

jreback commented Jan 3, 2016

closed by #11832

@jreback jreback closed this as completed Jan 3, 2016
@jreback jreback mentioned this issue Mar 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Datetime Datetime data dtype Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
0.18.0
Development

No branches or pull requests
1 participant
@jreback