read_hdf not supporting pathlib.Path

[michaelaye]

According to the Enhancements text for 17.1:

pd.read_* functions can now also accept pathlib.Path, or py._path.local.LocalPath objects for the filepath_or_buffer argument. (GH11033)

all read_* functions should support pathlib.Path now. It works for me with read_csv but not for read_hdf.
Interestingly, I find in the squashed PR for this issue, 0d3dcbb, only a comment regarding read_csv and read_table, while the merge 82f0033 talks about read_*. Is there something missing for read_hdf ?

[jreback]

yeh, this was not tested on all of the IO formats. pretty sure that csv/excel/stat/msgpack/json should work as they all use the same io calls. HDF uses a slightly different one as it doesn't support reading from buffers in the same way.

So need tests for each of these formats (and not just the IO call itself) on read/to
HDF test/fix

cc @flying-sheep

[flying-sheep]

jup, you told me

here is where all of this path inference is done (well not 100% sure of all but vast majority)

so it only was the vast majority, not all 😄

PS: the link is broken by now (tip: press y on some github page to get a canonical url so that this doesn’t happen anymore)

[michaelaye]

to_csv also does not support pathlib.Path yet. (v0.17.1), while read_csv does, interestingly.