Skip to content

ENH: Time zone support with PeriodIndex #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wesm opened this issue Apr 29, 2012 · 4 comments
Closed

ENH: Time zone support with PeriodIndex #1159

wesm opened this issue Apr 29, 2012 · 4 comments
Labels
Datetime Datetime data dtype Enhancement Period Period data type Timezones Timezone data dtype

Comments

@wesm
Copy link
Member

wesm commented Apr 29, 2012

This might be quite a bit of work, maybe leave for post 0.8.0
@jreback jreback modified the milestones: Someday, 0.14.0 Mar 9, 2014
@jbrockmendel
Copy link
Member

It is clear what this means in the context of freq='s', 'ms', 'us', effectively lower-resolution Timestamps. Is the idea here to also apply timezones to arbitrary frequencies, e.g. BQuarterEnd?

@wesm
Copy link
Member Author

wesm commented Jul 6, 2018

Closing as won't fix

@wesm wesm closed this as completed Jul 6, 2018
@wesm wesm added the Won't Fix label Jul 6, 2018
@jreback jreback modified the milestones: Someday, won't fix Jul 6, 2018
@TomAugspurger TomAugspurger modified the milestones: won't fix, No action Jul 6, 2018
@jbrockmendel jbrockmendel mentioned this issue Jul 7, 2018
Closed
samatix pushed a commit to samatix/zipline that referenced this issue Jan 10, 2020
BUG: Making the class UTC aware after creating the periodindex.
85f2f09 
This change to be dropped once pandas-dev/pandas#1159 and similar are completed in pandas
Using pytz UTC in the tests
samatix added a commit to samatix/zipline that referenced this issue Jan 17, 2020
@samatix
ENH: "UTC" to be used in the tz definition
4d34ffc 
[e2b5b857] MAINT: Adding explicit float conversion assert in the fetcher tests
[948a441b] BUG: Making the class UTC aware after creating the periodindex.
This change to be dropped once pandas-dev/pandas#1159 and similar are completed in pandas
[fa983434] BUG: Correcting issues in tests.data.test_adjustments.TestSQLiteAdjustmentsWriter and Sorting columns before asserting equal comparions
Using UTC in the test case as the trading calendar requires using UTC
Changing pandas.util.testing import to pandas.testing import from the highest release
@joooeey
Copy link
Contributor

joooeey commented May 12, 2022

Why is this a won't fix? It's quite the surprise that when you create a PeriodIndex with time zone aware arguments all in the same time zone, the result will be naive and there is not even a warning.

@simonjayhawkins
Copy link
Member

@joooeey can you add your comment to #45736 instead of this closed issue to help keep discussion in one place.

@simonjayhawkins simonjayhawkins added the Period Period data type label Jun 4, 2022
@simonjayhawkins simonjayhawkins changed the title Time zone support with PeriodIndex ENH: Time zone support with PeriodIndex Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Datetime Datetime data dtype Enhancement Period Period data type Timezones Timezone data dtype
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@wesm @jreback @TomAugspurger @jbrockmendel @simonjayhawkins @joooeey