COMPAT: openpyxl >= 2.2 failing #10125
Comments
jlec
changed the title
|
@Themanwithoutaplan perhaps you can help here. |
|
For fast solution replace this openpyxl upgraded their api and pandas also need to be updated for support openpyxl |
|
currently support for > 2.0 in All that said would be nice to have fixes for this. (Note that travis is not testing > 2.0.3) because conda hasn't accepted the updates to You could remove |
jreback
added
Testing
|
The styles API had to change for reliable functionality: individual cell styles are actually shared so changes had unpleasant side-effects. The In most other cases the API has become more standard and we do emit deprecation warnings. Test coverage has improved significantly but there are almost certainly still bugs in which case we need bug reports, ideally with relevant tests for the relevant parts of the library. |
|
FWIW... I have blindly (since forgotten that pandas uses openpyxl) uploaded fresh openpyxl beta release (2.3.0~b1) to debian sid and now enjoying similar failures full build log https://buildd.debian.org/status/fetch.php?pkg=pandas&arch=s390x&ver=0.16.2%2Bgit65-g054821d-1&stamp=1435856037&file=log |
This was necessary to handle an incompatibility between pandas and openpyxl. See http://stackoverflow.com/questions/30102232/pandas-can-not-write-to-excel-file and pandas-dev/pandas#10125
|
After a quick test in virtualenv This seems to work with openpyxl<=2.1.5 higher versions fail due to the style api changes. Personally, I'm setting my requirements.txt to include "openpyxl==1.8.6" until the 2 series API becomes stable. |
|
so here is a travis setup that can repro this: jreback@262c5f1 |
jreback
changed the title
jreback
changed the title
|
I would appreciate a fix as well. 2.3.0b2 is out and unlikely that API would break again I guess, so looking forward would be wise to get pandas ready |
Create separate environments for testing openpyxl. Subclass Openpyxl2Writer for >= 2.2 Add openpyxl >= 2.2 specific tests. Use class decorator for skipping TestClass Invert order for reading number format. Update docs. Allow openpyxl to handle the formatting for dates and times. Make function call clearer. Add version flag. Remove comments. Add a naive cache for styles.
|
closed via c6bcc99 |
|
AWESOME, thank you @jreback I will give it a shot! |
|
Great, thanks @jreback . Looking forward to the next release. |
|
Thanks, @jreback |
* commit 'v0.17.0rc1-92-gc6bcc99': (29 commits) CI: tests latest versions of openpyxl COMPAT: openpyxl >= 2.2 support, pandas-dev#10125 Tests demonstrating how to use sqlalchemy.text() objects in read_sql() TST: Capture warnings in _check_plot_works COMPAT/BUG: color handling in scatter COMPAT: Support for matplotlib 1.5 ERR/API: Raise NotImplementedError when Panel operator function is not implemented, pandas-dev#7692 DOC: minor doc formatting fixes PERF: nested dict DataFrame construction DEPR: deprecate SparsePanel BLD: dateutil->python-dateutil in conda recipe BUG/API: GH11086 where freq is not inferred if both freq is None ENH: add merge indicator to DataFrame.merge PERF: improves performance in groupby.size BUG: DatetimeTZBlock.fillna raises TypeError PERF: infer_datetime_format without padding pandas-dev#11142 PERF: improves performance in SeriesGroupBy.transform TST: Verify fix for buffer overflow in read_csv with engine='c' (GH pandas-dev#9735) DEPR: Series.is_timeseries BUG: nested construction with timedelta pandas-dev#11129 ...
xref #8342, #11008, #9747
a branch to repro on travis: jreback@262c5f1
The text was updated successfully, but these errors were encountered: