Replace _has_coplex_internals #29227

Author: Aivengoe

pandas/_libs/reduction.pyx

@@ -5,6 +5,8 @@ from cpython.ref cimport Py_INCREF
 
 from libc.stdlib cimport malloc, free
 
+from pandas.core.dtypes.generic import ABCMultiIndex
+
 import numpy as np
 cimport numpy as cnp
 from numpy cimport (ndarray,
@@ -492,7 +494,7 @@ def apply_frame_axis0(object frame, object f, object names,
         object piece
         dict item_cache
 
-    if frame.index._has_complex_internals:
+    if isinstance(frame.index, ABCMultiIndex):
         raise InvalidApply('Cannot modify frame index internals')
 
     results = []
@@ -624,7 +626,7 @@ def compute_reduction(arr, f, axis=0, dummy=None, labels=None):
 
     if labels is not None:
         # Caller is responsible for ensuring we don't have MultiIndex
-        assert not labels._has_complex_internals
+        assert not isinstance(frame.index, ABCMultiIndex),('MultiIndex type')
 
         # pass as an ndarray/ExtensionArray
         labels = labels._values

pandas/core/apply.py

@@ -5,6 +5,8 @@
 from pandas._libs import reduction as libreduction
 from pandas.util._decorators import cache_readonly
 
+from pandas.core.dtypes.generic import ABCMultiIndex
+
 from pandas.core.dtypes.common import (
     is_dict_like,
     is_extension_array_dtype,
@@ -231,7 +233,7 @@ def apply_standard(self):
             and not self.dtypes.apply(is_extension_array_dtype).any()
             # Disallow complex_internals since libreduction shortcut
             #  cannot handle MultiIndex
-            and not self.agg_axis._has_complex_internals
+            and not isinstance(self.agg_axis, ABCMultiIndex)
         ):
 
             values = self.values

pandas/core/groupby/ops.py

@@ -34,6 +34,7 @@
     is_timedelta64_dtype,
     needs_i8_conversion,
 )
+from pandas.core.dtypes.generic import ABCMultiIndex
 from pandas.core.dtypes.missing import _maybe_fill, isna
 
 import pandas.core.algorithms as algorithms
@@ -160,8 +161,7 @@ def apply(self, f, data, axis: int = 0):
             and hasattr(splitter, "fast_apply")
             and axis == 0
             # with MultiIndex, apply_frame_axis0 would raise InvalidApply
-            # TODO: can we make this check prettier?
-            and not sdata.index._has_complex_internals
+            and not isinstance(sdata.index, ABCMultiIndex)
         ):
             try:
                 result_values, mutated = splitter.fast_apply(f, group_keys)
@@ -172,7 +172,7 @@ def apply(self, f, data, axis: int = 0):
                     return group_keys, result_values, mutated
 
             except libreduction.InvalidApply as err:
-                # Cannot fast apply on MultiIndex (_has_complex_internals).
+                # Cannot fast apply on MultiIndex.
                 # This Exception is also raised if `f` triggers an exception
                 # but it is preferable to raise the exception in Python.
                 if "Let this error raise above us" not in str(err):
@@ -608,7 +608,7 @@ def agg_series(self, obj: Series, func):
             # TODO: is the datetime64tz case supposed to go through here?
             return self._aggregate_series_pure_python(obj, func)
 
-        elif obj.index._has_complex_internals:
+        elif isinstance(obj.index, ABCMultiIndex):
             # MultiIndex; Pre-empt TypeError in _aggregate_series_fast
             return self._aggregate_series_pure_python(obj, func)
 

pandas/core/indexes/base.py

@@ -4089,11 +4089,6 @@ def _assert_can_do_op(self, value):
             msg = "'value' must be a scalar, passed: {0}"
             raise TypeError(msg.format(type(value).__name__))
 
-    @property
-    def _has_complex_internals(self):
-        # to disable groupby tricks in MultiIndex
-        return False
-
     def _is_memory_usage_qualified(self):
         """
         Return a boolean if we need a qualified .info display.

pandas/core/indexes/multi.py

@@ -1396,11 +1396,6 @@ def values(self):
         self._tuples = lib.fast_zip(values)
         return self._tuples
 
-    @property
-    def _has_complex_internals(self):
-        # to disable groupby tricks
-        return True
-
     @cache_readonly
     def is_monotonic_increasing(self):
         """