Skip to content

Commit 8a13d06

Browse files
committed
delete second reindexing in _transform_general
1 parent 099e30c commit 8a13d06

File tree

2 files changed

+1
-30
lines changed

2 files changed

+1
-30
lines changed

pandas/core/groupby/generic.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -556,9 +556,7 @@ def _transform_general(
556556
if common_dtype is result.dtype:
557557
result = maybe_downcast_numeric(result, self._selected_obj.dtype)
558558

559-
obj = self._selected_obj.dropna() if self.dropna else self._selected_obj
560-
result.name = obj.name
561-
result.index = obj.index
559+
result.name = self._selected_obj.name
562560
return result
563561

564562
def _transform_fast(self, result) -> Series:

pandas/tests/groupby/test_grouping.py

-27
Original file line numberDiff line numberDiff line change
@@ -610,33 +610,6 @@ def test_list_grouper_with_nat(self):
610610
expected = {pd.Timestamp("2011-01-01"): 365}
611611
tm.assert_dict_equal(result.groups, expected)
612612

613-
@pytest.mark.parametrize(
614-
"func,expected",
615-
[
616-
(
617-
"transform",
618-
pd.Series(name=2, dtype=np.float64, index=pd.RangeIndex(0, 0, 1)),
619-
),
620-
(
621-
"agg",
622-
pd.Series(name=2, dtype=np.float64, index=pd.Float64Index([], name=1)),
623-
),
624-
(
625-
"apply",
626-
pd.Series(name=2, dtype=np.float64, index=pd.Float64Index([], name=1)),
627-
),
628-
],
629-
)
630-
def test_evaluate_with_empty_groups(self, func, expected):
631-
# 26208
632-
# test transform'ing empty groups
633-
# (not testing other agg fns, because they return
634-
# different index objects.
635-
df = pd.DataFrame({1: [], 2: []})
636-
g = df.groupby(1)
637-
result = getattr(g[2], func)(lambda x: x)
638-
tm.assert_series_equal(result, expected)
639-
640613
def test_groupby_empty(self):
641614
# https://github.com/pandas-dev/pandas/issues/27190
642615
s = pd.Series([], name="name", dtype="float64")

0 commit comments

Comments
 (0)