Skip to content

Commit 099e30c

Browse files
committed
added dropna=False to tests reliant on that
1 parent 640ec38 commit 099e30c

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

pandas/tests/groupby/transform/test_transform.py

+10-9
Original file line numberDiff line numberDiff line change
@@ -309,11 +309,11 @@ def test_transform_multiple(ts):
309309
def test_dispatch_transform(tsframe):
310310
df = tsframe[::5].reindex(tsframe.index)
311311

312-
grouped = df.groupby(lambda x: x.month)
312+
grouped = df.groupby(lambda x: x.month, dropna=False)
313313

314314
filled = grouped.fillna(method="pad")
315315
fillit = lambda x: x.fillna(method="pad")
316-
expected = df.groupby(lambda x: x.month).transform(fillit)
316+
expected = df.groupby(lambda x: x.month, dropna=False).transform(fillit)
317317
tm.assert_frame_equal(filled, expected)
318318

319319

@@ -412,10 +412,10 @@ def nsum(x):
412412
return np.nansum(x)
413413

414414
results = [
415-
df.groupby("col1").transform(sum)["col2"],
416-
df.groupby("col1")["col2"].transform(sum),
417-
df.groupby("col1").transform(nsum)["col2"],
418-
df.groupby("col1")["col2"].transform(nsum),
415+
df.groupby("col1", dropna=False).transform(sum)["col2"],
416+
df.groupby("col1", dropna=False)["col2"].transform(sum),
417+
df.groupby("col1", dropna=False).transform(nsum)["col2"],
418+
df.groupby("col1", dropna=False)["col2"].transform(nsum),
419419
]
420420
for result in results:
421421
tm.assert_series_equal(result, expected, check_names=False)
@@ -448,7 +448,9 @@ def test_groupby_transform_with_int():
448448
)
449449
)
450450
with np.errstate(all="ignore"):
451-
result = df.groupby("A").transform(lambda x: (x - x.mean()) / x.std())
451+
result = df.groupby("A", dropna=False).transform(
452+
lambda x: (x - x.mean()) / x.std()
453+
)
452454
expected = DataFrame(
453455
dict(B=np.nan, C=Series([-1, 0, 1, -1, 0, 1], dtype="float64"))
454456
)
@@ -612,8 +614,7 @@ def test_cython_transform_series(op, args, targop):
612614

613615
# series
614616
for data in [s, s_missing]:
615-
# print(data.head())
616-
expected = data.groupby(labels).transform(targop)
617+
expected = data.groupby(labels, dropna=False).transform(targop)
617618

618619
tm.assert_series_equal(expected, data.groupby(labels).transform(op, *args))
619620
tm.assert_series_equal(expected, getattr(data.groupby(labels), op)(*args))

0 commit comments

Comments
 (0)