Skip to content

Commit 640ec38

Browse files
committed
rewrote _set_result_index_ordered
1 parent a335744 commit 640ec38

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

pandas/core/groupby/generic.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -556,8 +556,9 @@ def _transform_general(
556556
if common_dtype is result.dtype:
557557
result = maybe_downcast_numeric(result, self._selected_obj.dtype)
558558

559-
result.name = self._selected_obj.name
560-
result.index = self._selected_obj.index
559+
obj = self._selected_obj.dropna() if self.dropna else self._selected_obj
560+
result.name = obj.name
561+
result.index = obj.index
561562
return result
562563

563564
def _transform_fast(self, result) -> Series:

pandas/core/groupby/groupby.py

+5-11
Original file line numberDiff line numberDiff line change
@@ -637,12 +637,10 @@ def _selected_obj(self):
637637

638638
if self._selection is None or isinstance(self.obj, Series):
639639
if self._group_selection is not None:
640-
result = self.obj[self._group_selection]
641-
result = self.obj
640+
return self.obj[self._group_selection]
641+
return self.obj
642642
else:
643-
result = self.obj[self._selection]
644-
645-
return result.dropna() if self.dropna else result
643+
return self.obj[self._selection]
646644

647645
def _reset_group_selection(self):
648646
"""
@@ -692,12 +690,8 @@ def _set_result_index_ordered(self, result):
692690
result.set_axis(index, axis=self.axis, inplace=True)
693691
result = result.sort_index(axis=self.axis)
694692

695-
if hasattr(self, "_selected_obj"):
696-
labels = self._selected_obj._get_axis(self.axis)
697-
else:
698-
labels = self.obj._get_axis(self.axis)
699-
700-
result.set_axis(labels, axis=self.axis, inplace=True)
693+
obj = self.obj.dropna() if self.dropna else self.obj
694+
result.set_axis(obj._get_axis(self.axis), axis=self.axis, inplace=True)
701695
return result
702696

703697
def _dir_additions(self):

0 commit comments

Comments
 (0)