Skip to content

Commit 60a2770

Browse files
committed
CLN: Convert assert_(x != y) to assertNotEqual
Work on #6175. Converts instances in pandas/tests and pandas/*/tests. Tests still pass locally.
1 parent e330b60 commit 60a2770

File tree

8 files changed

+27
-28
lines changed

8 files changed

+27
-28
lines changed

pandas/stats/tests/test_ols.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ def test_r2_no_intercept(self):
294294
assert_series_equal(model1.beta, model2.beta)
295295

296296
# TODO: can we infer whether the intercept is there...
297-
self.assert_(model1.r2 != model2.r2)
297+
self.assertNotEqual(model1.r2, model2.r2)
298298

299299
# rolling
300300

pandas/tests/test_format.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,7 @@ def test_wide_repr(self):
798798
assert "10 rows x %d columns" % (max_cols - 1) in rep_str
799799
set_option('display.expand_frame_repr', True)
800800
wide_repr = repr(df)
801-
self.assert_(rep_str != wide_repr)
801+
self.assertNotEqual(rep_str, wide_repr)
802802

803803
with option_context('display.width', 120):
804804
wider_repr = repr(df)
@@ -824,7 +824,7 @@ def test_wide_repr_named(self):
824824
rep_str = repr(df)
825825
set_option('display.expand_frame_repr', True)
826826
wide_repr = repr(df)
827-
self.assert_(rep_str != wide_repr)
827+
self.assertNotEqual(rep_str, wide_repr)
828828

829829
with option_context('display.width', 150):
830830
wider_repr = repr(df)
@@ -848,7 +848,7 @@ def test_wide_repr_multiindex(self):
848848
rep_str = repr(df)
849849
set_option('display.expand_frame_repr', True)
850850
wide_repr = repr(df)
851-
self.assert_(rep_str != wide_repr)
851+
self.assertNotEqual(rep_str, wide_repr)
852852

853853
with option_context('display.width', 150):
854854
wider_repr = repr(df)
@@ -874,7 +874,7 @@ def test_wide_repr_multiindex_cols(self):
874874
rep_str = repr(df)
875875
set_option('display.expand_frame_repr', True)
876876
wide_repr = repr(df)
877-
self.assert_(rep_str != wide_repr)
877+
self.assertNotEqual(rep_str, wide_repr)
878878

879879
with option_context('display.width', 150):
880880
wider_repr = repr(df)
@@ -891,7 +891,7 @@ def test_wide_repr_unicode(self):
891891
rep_str = repr(df)
892892
set_option('display.expand_frame_repr', True)
893893
wide_repr = repr(df)
894-
self.assert_(rep_str != wide_repr)
894+
self.assertNotEqual(rep_str, wide_repr)
895895

896896
with option_context('display.width', 150):
897897
wider_repr = repr(df)

pandas/tests/test_frame.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -8835,7 +8835,7 @@ def test_rename_inplace(self):
88358835

88368836
self.assert_('C' not in frame)
88378837
self.assert_('foo' in frame)
8838-
self.assert_(id(frame['foo']) != c_id)
8838+
self.assertNotEqual(id(frame['foo']), c_id)
88398839

88408840
def test_rename_bug(self):
88418841
# GH 5344
@@ -9577,7 +9577,7 @@ def test_sort_index_inplace(self):
95779577
df.sort_index(inplace=True)
95789578
expected = frame
95799579
assert_frame_equal(df, expected)
9580-
self.assert_(a_id != id(df['A']))
9580+
self.assertNotEqual(a_id, id(df['A']))
95819581

95829582
df = unordered.copy()
95839583
df.sort_index(ascending=False, inplace=True)

pandas/tests/test_panel.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1358,7 +1358,7 @@ def test_swapaxes(self):
13581358
# this works, but return a copy
13591359
result = self.panel.swapaxes('items', 'items')
13601360
assert_panel_equal(self.panel,result)
1361-
self.assert_(id(self.panel) != id(result))
1361+
self.assertNotEqual(id(self.panel), id(result))
13621362

13631363
def test_transpose(self):
13641364
result = self.panel.transpose('minor', 'major', 'items')

pandas/tests/test_panel4d.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -872,7 +872,7 @@ def test_swapaxes(self):
872872
# this works, but return a copy
873873
result = self.panel4d.swapaxes('items', 'items')
874874
assert_panel4d_equal(self.panel4d,result)
875-
self.assert_(id(self.panel4d) != id(result))
875+
self.assertNotEqual(id(self.panel4d), id(result))
876876

877877
def test_to_frame(self):
878878
raise nose.SkipTest("skipping for now")

pandas/tseries/tests/test_offsets.py

-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ def test_eq(self):
150150
offset1 = DateOffset(days=1)
151151
offset2 = DateOffset(days=365)
152152

153-
self.assert_(offset1 != offset2)
154153
self.assertNotEqual(offset1, offset2)
155154

156155

pandas/tseries/tests/test_period.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ def test_period_constructor(self):
199199

200200
def test_freq_str(self):
201201
i1 = Period('1982', freq='Min')
202-
self.assert_(i1.freq[0] != '1')
202+
self.assertNotEqual(i1.freq[0], '1')
203203

204204
def test_repr(self):
205205
p = Period('Jan-2000')

pandas/tseries/tests/test_timeseries.py

+16-16
Original file line numberDiff line numberDiff line change
@@ -1729,9 +1729,9 @@ def test_timestamp_compare_with_early_datetime(self):
17291729
self.assertFalse(stamp == datetime.min)
17301730
self.assertFalse(stamp == datetime(1600, 1, 1))
17311731
self.assertFalse(stamp == datetime(2700, 1, 1))
1732-
self.assert_(stamp != datetime.min)
1733-
self.assert_(stamp != datetime(1600, 1, 1))
1734-
self.assert_(stamp != datetime(2700, 1, 1))
1732+
self.assertNotEqual(stamp, datetime.min)
1733+
self.assertNotEqual(stamp, datetime(1600, 1, 1))
1734+
self.assertNotEqual(stamp, datetime(2700, 1, 1))
17351735
self.assert_(stamp > datetime(1600, 1, 1))
17361736
self.assert_(stamp >= datetime(1600, 1, 1))
17371737
self.assert_(stamp < datetime(2700, 1, 1))
@@ -2593,28 +2593,28 @@ def test_comparison(self):
25932593
val = Timestamp(stamp)
25942594

25952595
self.assertEqual(val, val)
2596-
self.assert_(not val != val)
2597-
self.assert_(not val < val)
2596+
self.assertFalse(val != val)
2597+
self.assertFalse(val < val)
25982598
self.assert_(val <= val)
2599-
self.assert_(not val > val)
2599+
self.assertFalse(val > val)
26002600
self.assert_(val >= val)
26012601

26022602
other = datetime(2012, 5, 18)
26032603
self.assertEqual(val, other)
2604-
self.assert_(not val != other)
2605-
self.assert_(not val < other)
2606-
self.assert_(val <= other)
2607-
self.assert_(not val > other)
2608-
self.assert_(val >= other)
2604+
self.assertFalse(val != other)
2605+
self.assertFalse(val < other)
2606+
self.assertTrue(val <= other)
2607+
self.assertFalse(val > other)
2608+
self.assertTrue(val >= other)
26092609

26102610
other = Timestamp(stamp + 100)
26112611

26122612
self.assertNotEqual(val, other)
2613-
self.assert_(val != other)
2614-
self.assert_(val < other)
2615-
self.assert_(val <= other)
2616-
self.assert_(other > val)
2617-
self.assert_(other >= val)
2613+
self.assertNotEqual(val, other)
2614+
self.assertTrue(val < other)
2615+
self.assertTrue(val <= other)
2616+
self.assertTrue(other > val)
2617+
self.assertTrue(other >= val)
26182618

26192619
def test_cant_compare_tz_naive_w_aware(self):
26202620
_skip_if_no_pytz()

0 commit comments

Comments
 (0)