Skip to content

Commit e330b60

Browse files
committed
CLN: Convert last of assert_(x == y) to assertEqual
Work on #6175. Fixes last of vanilla assert_(x == y) conversions in pandas/tests and pandas/*/tests. Tests still pass locally.
1 parent b5b7436 commit e330b60

File tree

5 files changed

+26
-25
lines changed

5 files changed

+26
-25
lines changed

pandas/io/tests/test_json/test_ujson.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -387,16 +387,16 @@ def test_datetime_units(self):
387387
stamp = Timestamp(val)
388388

389389
roundtrip = ujson.decode(ujson.encode(val, date_unit='s'))
390-
self.assert_(roundtrip == stamp.value // 10**9)
390+
self.assertEqual(roundtrip, stamp.value // 10**9)
391391

392392
roundtrip = ujson.decode(ujson.encode(val, date_unit='ms'))
393-
self.assert_(roundtrip == stamp.value // 10**6)
393+
self.assertEqual(roundtrip, stamp.value // 10**6)
394394

395395
roundtrip = ujson.decode(ujson.encode(val, date_unit='us'))
396-
self.assert_(roundtrip == stamp.value // 10**3)
396+
self.assertEqual(roundtrip, stamp.value // 10**3)
397397

398398
roundtrip = ujson.decode(ujson.encode(val, date_unit='ns'))
399-
self.assert_(roundtrip == stamp.value)
399+
self.assertEqual(roundtrip, stamp.value)
400400

401401
self.assertRaises(ValueError, ujson.encode, val, date_unit='foo')
402402

pandas/io/tests/test_pytables.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -3140,7 +3140,8 @@ def test_retain_index_attributes(self):
31403140

31413141
for attr in ['freq','tz','name']:
31423142
for idx in ['index','columns']:
3143-
self.assert_(getattr(getattr(df,idx),attr,None) == getattr(getattr(result,idx),attr,None))
3143+
self.assertEqual(getattr(getattr(df,idx),attr,None),
3144+
getattr(getattr(result,idx),attr,None))
31443145

31453146

31463147
# try to append a table with a different frequency

pandas/tests/test_frame.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -1563,24 +1563,24 @@ def test_set_value_with_index_dtype_change(self):
15631563
# so column is not created
15641564
df = df_orig.copy()
15651565
df.set_value('C', 2, 1.0)
1566-
self.assert_(list(df.index) == list(df_orig.index) + ['C'])
1567-
#self.assert_(list(df.columns) == list(df_orig.columns) + [2])
1566+
self.assertEqual(list(df.index), list(df_orig.index) + ['C'])
1567+
#self.assertEqual(list(df.columns), list(df_orig.columns) + [2])
15681568

15691569
df = df_orig.copy()
15701570
df.loc['C', 2] = 1.0
1571-
self.assert_(list(df.index) == list(df_orig.index) + ['C'])
1572-
#self.assert_(list(df.columns) == list(df_orig.columns) + [2])
1571+
self.assertEqual(list(df.index), list(df_orig.index) + ['C'])
1572+
#self.assertEqual(list(df.columns), list(df_orig.columns) + [2])
15731573

15741574
# create both new
15751575
df = df_orig.copy()
15761576
df.set_value('C', 'D', 1.0)
1577-
self.assert_(list(df.index) == list(df_orig.index) + ['C'])
1578-
self.assert_(list(df.columns) == list(df_orig.columns) + ['D'])
1577+
self.assertEqual(list(df.index), list(df_orig.index) + ['C'])
1578+
self.assertEqual(list(df.columns), list(df_orig.columns) + ['D'])
15791579

15801580
df = df_orig.copy()
15811581
df.loc['C', 'D'] = 1.0
1582-
self.assert_(list(df.index) == list(df_orig.index) + ['C'])
1583-
self.assert_(list(df.columns) == list(df_orig.columns) + ['D'])
1582+
self.assertEqual(list(df.index), list(df_orig.index) + ['C'])
1583+
self.assertEqual(list(df.columns), list(df_orig.columns) + ['D'])
15841584

15851585
def test_get_set_value_no_partial_indexing(self):
15861586
# partial w/ MultiIndex raise exception

pandas/tseries/tests/test_offsets.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -774,7 +774,7 @@ def test_onOffset(self):
774774

775775
for weekday, date, expected in test_cases:
776776
offset = LastWeekOfMonth(weekday=weekday)
777-
self.assert_(offset.onOffset(date) == expected, date)
777+
self.assertEqual(offset.onOffset(date), expected, msg=date)
778778

779779

780780
class TestBMonthBegin(TestBase):

pandas/tseries/tests/test_period.py

+11-11
Original file line numberDiff line numberDiff line change
@@ -1191,19 +1191,19 @@ def test_is_(self):
11911191
create_index = lambda: PeriodIndex(freq='A', start='1/1/2001',
11921192
end='12/1/2009')
11931193
index = create_index()
1194-
self.assertTrue(index.is_(index))
1195-
self.assertFalse(index.is_(create_index()))
1196-
self.assertTrue(index.is_(index.view()))
1197-
self.assertTrue(index.is_(index.view().view().view().view().view()))
1198-
self.assertTrue(index.view().is_(index))
1194+
self.assertEqual(index.is_(index), True)
1195+
self.assertEqual(index.is_(create_index()), False)
1196+
self.assertEqual(index.is_(index.view()), True)
1197+
self.assertEqual(index.is_(index.view().view().view().view().view()), True)
1198+
self.assertEqual(index.view().is_(index), True)
11991199
ind2 = index.view()
12001200
index.name = "Apple"
1201-
self.assertTrue(ind2.is_(index))
1202-
self.assertFalse(index.is_(index[:]))
1203-
self.assertFalse(index.is_(index.asfreq('M')))
1204-
self.assertFalse(index.is_(index.asfreq('A')))
1205-
self.assertFalse(index.is_(index - 2))
1206-
self.assertFalse(index.is_(index - 0))
1201+
self.assertEqual(ind2.is_(index), True)
1202+
self.assertEqual(index.is_(index[:]), False)
1203+
self.assertEqual(index.is_(index.asfreq('M')), False)
1204+
self.assertEqual(index.is_(index.asfreq('A')), False)
1205+
self.assertEqual(index.is_(index - 2), False)
1206+
self.assertEqual(index.is_(index - 0), False)
12071207

12081208
def test_comp_period(self):
12091209
idx = period_range('2007-01', periods=20, freq='M')

0 commit comments

Comments
 (0)