Skip to content

Commit 41d10b5

Browse files
committed
Merge pull request #4719 from jtratner/contributing-update
DOC: Updates to CONTRIBUTING.md
2 parents 958f214 + 002a4ad commit 41d10b5

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

CONTRIBUTING.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ your contribution or address the issue you're having.
3232
- **Make sure the test suite passes**., and that means on python3 as well.
3333
You can use "test_fast.sh", or tox locally and/or enable Travis-CI on your fork.
3434
See the "Getting Travis-CI going" below.
35-
- We suggest you enable Travis-CI on your fork, to make it easier for the team
36-
to see that the PR does indeed pass all the tests.
35+
- If you are changing any code, you need to enable Travis-CI on your fork,
36+
to make it easier for the team to see that the PR does indeed pass all the tests.
3737
- Back-compatibility **really** matters. Pandas already has a large user-base and
3838
a lot of existing user code. Don't break old code if you can avoid it
3939
Explain the need if there is one in the PR.
@@ -69,7 +69,8 @@ your contribution or address the issue you're having.
6969
with self.assertRaises(ValueError):
7070
foo
7171
72-
which fails on python 2.6, use `self.assertRaises(TheException,func,args)` instead.
72+
which fails on python 2.6. You need to use `assertRaises` from
73+
`pandas.util.testing` instead (or use `self.assertRaises(TheException,func,args)`).
7374
7475
- doc/source/release.rst and doc/source/vx.y.z.txt contain an on-going
7576
changelog for each release as it is worked on. Add entries to these files

0 commit comments

Comments
 (0)