@@ -32,8 +32,8 @@ your contribution or address the issue you're having.
32
32
- **Make sure the test suite passes**., and that means on python3 as well.
33
33
You can use "test_fast.sh", or tox locally and/or enable Travis-CI on your fork.
34
34
See the "Getting Travis-CI going" below.
35
- - We suggest you enable Travis-CI on your fork, to make it easier for the team
36
- to see that the PR does indeed pass all the tests.
35
+ - If you are changing any code, you need to enable Travis-CI on your fork,
36
+ to make it easier for the team to see that the PR does indeed pass all the tests.
37
37
- Back-compatibility **really** matters. Pandas already has a large user-base and
38
38
a lot of existing user code. Don't break old code if you can avoid it
39
39
Explain the need if there is one in the PR.
@@ -69,7 +69,8 @@ your contribution or address the issue you're having.
69
69
with self.assertRaises(ValueError):
70
70
foo
71
71
72
- which fails on python 2.6, use `self.assertRaises(TheException,func,args)` instead.
72
+ which fails on python 2.6. You need to use `assertRaises` from
73
+ `pandas.util.testing` instead (or use `self.assertRaises(TheException,func,args)`).
73
74
74
75
- doc/source/release.rst and doc/source/vx.y.z.txt contain an on-going
75
76
changelog for each release as it is worked on. Add entries to these files
0 commit comments