Skip to content

Fixed Index.rename() and added test #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 3, 2024
Merged

Fixed Index.rename() and added test #936

merged 5 commits into from
Jun 3, 2024

Conversation

devesh-2002
Copy link
Contributor

Dr-Irv
Dr-Irv requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix the test

Dr-Irv
Dr-Irv requested changes Jun 3, 2024
View reviewed changes
Dr-Irv
Dr-Irv requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The precommit is failing. You need to run black on test_indexes.py .

Dr-Irv
Dr-Irv approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @devesh-2002

@Dr-Irv Dr-Irv merged commit 73d5501 into pandas-dev:main Jun 3, 2024
13 checks passed
@devesh-2002
Copy link
Contributor Author

Thanks a lot for the help! @Dr-Irv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devesh-2002 @Dr-Irv