fix concat for axis=0 #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Mar 2, 2024
| @@ -77,8 +82,8 @@ def test_types_concat_none() -> None: | |||
|
|
|||
|
|
|||
| def test_types_concat() -> None: | |||
| s: pd.Series = pd.Series([0, 1, -10]) | |||
| s2: pd.Series = pd.Series([7, -5, 10]) | |||
There was a problem hiding this comment.
These two annotations messed mypy in the previous commit. up
|
thanks for the fix. @Dr-Irv any idea when the next release will be? |
I usually wait for a number of PR's to come through before doing a release. We've only had 3 since the last release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #879
Works on pyright - mypy behaves weirdly (the 3rd overload is clearly the first matching overload). @Dr-Irv, feel free to change this PR - not sure whether I will have time to debug the mypy issue before the weekend.