-
-
Notifications
You must be signed in to change notification settings - Fork 141
Rework groupby and resample core modules #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c5a98cf
Rework groupby and resample core modules
hamdanal 0ec4cbc
Runtime Series is not generic
hamdanal fce36b6
Remove default values and deprecated
hamdanal 50a2477
Use np.integer in tests
hamdanal b9271da
Add a comment for Incomplete
hamdanal a8a71c1
Remove private objects
hamdanal 9a0cb64
Remove deprecated Resampler.fillna
hamdanal 2ba2d10
Remove private constructors
hamdanal 8d4bab2
Remove more private constructors
hamdanal 8e2362d
Temporarily type labelsize as int
hamdanal 0631f07
Tighten rolling and expanding method type
hamdanal ca4f934
Remove step from groupby rolling
hamdanal 3c6a688
Fix resample rule
hamdanal 92c45ba
Fix groupby fillna
hamdanal da04d2e
Add missing test for linked issue
hamdanal 12843df
Remove pandas.core.apply as it is not used in public code
hamdanal 6d0c408
Address CR
hamdanal 19ef720
Address remaining CR
hamdanal 83c7dcb
revert pyproject change
hamdanal 831241a
Temporarily pin pyright to unblock CI
hamdanal 38cf1d9
New deprecations
hamdanal 935aa65
Windows tests
hamdanal 875cb0d
Apply suggestions from code review
hamdanal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use
self
here (and in the other overloads)?