OffsetSeries inherits from Series[BaseOffset] #844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I honestly would prefer to remove
OffsetSeries
and replace it withSeries[Any]
(personally, I'm not keen on maintaining operators for Series as there is no generic solution #820). If we want to keep this class, it would make sense to let it inherit fromSeries[BaseOffset]
instead ofSeries[Any/Unknown]