Skip to content

OffsetSeries inherits from Series[BaseOffset] #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

twoertwein
Copy link
Member

I honestly would prefer to remove OffsetSeries and replace it with Series[Any] (personally, I'm not keen on maintaining operators for Series as there is no generic solution #820). If we want to keep this class, it would make sense to let it inherit from Series[BaseOffset] instead of Series[Any/Unknown]

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @twoertwein

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Dec 24, 2023

I honestly would prefer to remove OffsetSeries and replace it with Series[Any] (personally, I'm not keen on maintaining operators for Series as there is no generic solution #820). If we want to keep this class, it would make sense to let it inherit from Series[BaseOffset] instead of Series[Any/Unknown]

that makes sense. Good improvement.

@twoertwein
Copy link
Member Author

This could potentially hit people who rely on methods provided only by sub-types of BaseOffset.

@Dr-Irv Dr-Irv merged commit 146cf23 into pandas-dev:main Dec 26, 2023
@twoertwein twoertwein deleted the baseoffset branch February 10, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants